From: Hangbin Liu <liuhangbin@gmail.com>
To: netdev@vger.kernel.org
Cc: bpf@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
linux-kselftest@vger.kernel.org,
"David S . Miller" <davem@davemloft.net>,
Jiri Benc <jbenc@redhat.com>, Hangbin Liu <liuhangbin@gmail.com>
Subject: [PATCH bpf 3/4] selftests/bpf/xdp_redirect_multi: give tcpdump a chance to terminate cleanly
Date: Wed, 27 Oct 2021 11:35:52 +0800 [thread overview]
Message-ID: <20211027033553.962413-4-liuhangbin@gmail.com> (raw)
In-Reply-To: <20211027033553.962413-1-liuhangbin@gmail.com>
No need to kill tcpdump with -9.
Suggested-by: Jiri Benc <jbenc@redhat.com>
Fixes: d23292476297 ("selftests/bpf: Add xdp_redirect_multi test")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
---
tools/testing/selftests/bpf/test_xdp_redirect_multi.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/bpf/test_xdp_redirect_multi.sh b/tools/testing/selftests/bpf/test_xdp_redirect_multi.sh
index c2a933caa32d..37e347159ab4 100755
--- a/tools/testing/selftests/bpf/test_xdp_redirect_multi.sh
+++ b/tools/testing/selftests/bpf/test_xdp_redirect_multi.sh
@@ -106,7 +106,7 @@ do_egress_tests()
sleep 0.5
ip netns exec ns1 ping 192.0.2.254 -i 0.1 -c 4 &> /dev/null
sleep 0.5
- pkill -9 tcpdump
+ pkill tcpdump
# mac check
grep -q "${veth_mac[2]} > ff:ff:ff:ff:ff:ff" ${LOG_DIR}/mac_ns1-2_${mode}.log && \
@@ -133,7 +133,7 @@ do_ping_tests()
# IPv6 test
ip netns exec ns1 ping6 2001:db8::2 -i 0.1 -c 2 &> /dev/null
sleep 0.5
- pkill -9 tcpdump
+ pkill tcpdump
# All netns should receive the redirect arp requests
[ $(grep -cF "who-has 192.0.2.254" ${LOG_DIR}/ns1-1_${mode}.log) -eq 4 ] && \
--
2.31.1
next prev parent reply other threads:[~2021-10-27 3:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 3:35 [PATCH bpf 0/4] Fix some issues for selftest test_xdp_redirect_multi.sh Hangbin Liu
2021-10-27 3:35 ` [PATCH bpf 1/4] selftests/bpf/xdp_redirect_multi: put the logs to tmp folder Hangbin Liu
2021-10-27 3:35 ` [PATCH bpf 2/4] selftests/bpf/xdp_redirect_multi: use arping to accurate the arp number Hangbin Liu
2021-10-27 3:35 ` Hangbin Liu [this message]
2021-10-27 3:35 ` [PATCH bpf 4/4] selftests/bpf/xdp_redirect_multi: limit the tests in netns Hangbin Liu
2021-11-05 15:46 ` [PATCH bpf 0/4] Fix some issues for selftest test_xdp_redirect_multi.sh Daniel Borkmann
2021-11-08 2:15 ` Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211027033553.962413-4-liuhangbin@gmail.com \
--to=liuhangbin@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=hawk@kernel.org \
--cc=jbenc@redhat.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.