Re: [RFC PATCH v7 02/16] ipe: add policy parser

From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [RFC PATCH v7 02/16] ipe: add policy parser
Date: Wed, 27 Oct 2021 13:58:17 +0800	[thread overview]
Message-ID: <202110271344.Ir5QoOKL-lkp@intel.com> (raw)
In-Reply-To: <1634151995-16266-3-git-send-email-deven.desai@linux.microsoft.com>

[-- Attachment #1: Type: text/plain, Size: 4466 bytes --]

Hi,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on device-mapper-dm/for-next]
[also build test WARNING on linus/master jmorris-security/next-testing v5.15-rc7 next-20211026]
[cannot apply to fscrypt/fsverity]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/deven-desai-linux-microsoft-com/Integrity-Policy-Enforcement-IPE/20211014-030810
base:   https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git for-next
config: openrisc-randconfig-r002-20211027 (attached as .config)
compiler: or1k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/f209aa6c4ffb6565951bbbe0d0ccec06fd214fac
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review deven-desai-linux-microsoft-com/Integrity-Policy-Enforcement-IPE/20211014-030810
        git checkout f209aa6c4ffb6565951bbbe0d0ccec06fd214fac
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=openrisc SHELL=/bin/bash security/ipe/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> security/ipe/policy.c:327: warning: expecting prototype for ipe_tokenize_line(). Prototype was for tokenize_line() instead
   security/ipe/policy.c:406: warning: Function parameter or member 'tokens' not described in 'parse_pass1'
   security/ipe/policy.c:449: warning: Function parameter or member 'pol' not described in 'parse_pass2'
   security/ipe/policy.c:449: warning: Excess function parameter 'p' description in 'parse_pass2'
   security/ipe/policy.c:736: warning: Function parameter or member 'p' not described in 'validate_policy'
   security/ipe/policy.c:736: warning: Excess function parameter 'policy' description in 'validate_policy'
>> security/ipe/policy.c:866: warning: expecting prototype for ipe_free_policy(). Prototype was for ipe_put_policy() instead

vim +327 security/ipe/policy.c

   313	
   314	/**
   315	 * ipe_tokenize_line: Parse a line of text into a list of token structures.
   316	 * @line: Supplies the line to parse.
   317	 *
   318	 * The final result can be NULL, which represents no tokens were parsed.
   319	 *
   320	 * Return:
   321	 * !0 - OK
   322	 * NULL - OK, no tokens were parsed.
   323	 * ERR_PTR(-EBADMSG) - Invalid policy syntax
   324	 * ERR_PTR(-ENOMEM) - No Memory
   325	 */
   326	static struct ipe_policy_line *tokenize_line(char *line)
 > 327	{
   328		int rc = 0;
   329		size_t i = 0;
   330		size_t len = 0;
   331		char *tok = NULL;
   332		char quote = '\0';
   333		struct ipe_policy_line *p = NULL;
   334	
   335		/* nullterm guaranteed by strsep */
   336		len = strlen(line);
   337	
   338		for (i = 0; i < len; ++i) {
   339			if (quote == '\0' && is_quote(line[i])) {
   340				quote = line[i];
   341				continue;
   342			}
   343	
   344			if (quote != '\0' && line[i] == quote) {
   345				quote = '\0';
   346				continue;
   347			}
   348	
   349			if (quote == '\0' && line[i] == START_COMMENT) {
   350				tok = NULL;
   351				break;
   352			}
   353	
   354			if (isgraph(line[i]) && !tok)
   355				tok = &line[i];
   356	
   357			if (quote == '\0' && isspace(line[i])) {
   358				line[i] = '\0';
   359	
   360				if (!tok)
   361					continue;
   362	
   363				rc = insert_token(tok, &p);
   364				if (rc)
   365					goto err;
   366	
   367				tok = NULL;
   368			}
   369		}
   370	
   371		if (quote != '\0') {
   372			rc = -EBADMSG;
   373			goto err;
   374		}
   375	
   376		if (tok) {
   377			rc = insert_token(tok, &p);
   378			if (rc)
   379				goto err;
   380		}
   381	
   382		return p;
   383	
   384	err:
   385		free_parsed_line(p);
   386		return ERR_PTR(rc);
   387	}
   388	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 30944 bytes --]