From: Ian Rogers <irogers@google.com>
To: Andi Kleen <ak@linux.intel.com>, Jiri Olsa <jolsa@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
John Garry <john.garry@huawei.com>,
Kajol Jain <kjain@linux.ibm.com>,
"Paul A . Clarke" <pc@us.ibm.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Riccardo Mancini <rickyman7@gmail.com>,
Kan Liang <kan.liang@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Song Liu <song@kernel.org>, Wan Jiabing <wanjiabing@vivo.com>,
Yury Norov <yury.norov@gmail.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Ian Rogers <irogers@google.com>
Subject: [PATCH v2 0/8] New function and literals for metrics
Date: Wed, 10 Nov 2021 16:21:01 -0800 [thread overview]
Message-ID: <20211111002109.194172-1-irogers@google.com> (raw)
Add a test for hyphenated events that are common with Intel's icelake
topdown events.
Try to tidy the existing cputopo code and make it more consistent with
the sysfs ABI. Refactor the #smt_on literal parsing into a general
literal token that we can use for more literals. This is then used for
num_cpus, num_cores, num_dies and num_packages literals that use the
existing topology code. Finally, a source_count function is added
which is used to determine the number of events contributing to an
aggregate event. The intent for these new literals and function is for
them to be used in upcoming metrics.
v2. Split the handle_id function refactor out of adding the
source_count function as suggested-by Jiri Olsa <jolsa@kernel.org>.
Ian Rogers (8):
perf test: Add expr test for events with hyphens
perf cputopo: Update to use pakage_cpus
perf cputopo: Match die_siblings to topology ABI name
perf cputopo: Match thread_siblings to topology ABI name
perf expr: Add literal values starting with #
perf expr: Add metric literals for topology.
perf expr: Move ID handling to its own function
perf expr: Add source_count for aggregating events
tools/perf/tests/expr.c | 34 ++++++++++++++-
tools/perf/util/cputopo.c | 78 ++++++++++++++++++-----------------
tools/perf/util/cputopo.h | 33 ++++++++++++---
tools/perf/util/evsel.c | 12 ++++++
tools/perf/util/evsel.h | 1 +
tools/perf/util/expr.c | 65 ++++++++++++++++++++++++++---
tools/perf/util/expr.h | 4 ++
tools/perf/util/expr.l | 16 ++++++-
tools/perf/util/expr.y | 72 ++++++++++++++++++--------------
tools/perf/util/header.c | 20 ++++-----
tools/perf/util/stat-shadow.c | 7 +++-
11 files changed, 250 insertions(+), 92 deletions(-)
--
2.34.0.rc1.387.gb447b232ab-goog
next reply other threads:[~2021-11-11 0:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 0:21 Ian Rogers [this message]
2021-11-11 0:21 ` [PATCH v2 1/8] perf test: Add expr test for events with hyphens Ian Rogers
2021-11-11 0:21 ` [PATCH v2 2/8] perf cputopo: Update to use pakage_cpus Ian Rogers
2021-11-11 0:21 ` [PATCH v2 3/8] perf cputopo: Match die_siblings to topology ABI name Ian Rogers
2021-11-11 0:21 ` [PATCH v2 4/8] perf cputopo: Match thread_siblings " Ian Rogers
2021-11-11 0:21 ` [PATCH v2 5/8] perf expr: Add literal values starting with # Ian Rogers
2021-11-11 0:21 ` [PATCH v2 6/8] perf expr: Add metric literals for topology Ian Rogers
2021-11-11 0:21 ` [PATCH v2 7/8] perf expr: Move ID handling to its own function Ian Rogers
2021-11-11 8:21 ` Jiri Olsa
2021-11-11 13:42 ` Arnaldo Carvalho de Melo
2021-11-11 0:21 ` [PATCH v2 8/8] perf expr: Add source_count for aggregating events Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211111002109.194172-1-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=john.garry@huawei.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@linux.intel.com \
--cc=kjain@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=maddy@linux.ibm.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=pc@us.ibm.com \
--cc=peterz@infradead.org \
--cc=rickyman7@gmail.com \
--cc=song@kernel.org \
--cc=wanjiabing@vivo.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.