From: Pavan Kondeti <quic_pkondeti@quicinc.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Pavankumar Kondeti <quic_pkondeti@quicinc.com>,
<linux-kernel@vger.kernel.org>, <linux-usb@vger.kernel.org>,
Felipe Balbi <balbi@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Peter Chen <peter.chen@nxp.com>, Jack Pham <jackp@codeaurora.org>,
Dean Anderson <dean@sensoray.com>,
Salah Triki <salah.triki@gmail.com>,
Andrew Gabbasov <andrew_gabbasov@mentor.com>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] usb: gadget: f_fs: Use stream_open() for endpoint files
Date: Thu, 11 Nov 2021 17:36:36 +0530 [thread overview]
Message-ID: <20211111120636.GA11612@hu-pkondeti-hyd.qualcomm.com> (raw)
In-Reply-To: <YY0Asjnm/Ce6FpS8@kroah.com>
Hi Greg,
On Thu, Nov 11, 2021 at 12:38:26PM +0100, Greg Kroah-Hartman wrote:
> On Thu, Nov 11, 2021 at 04:41:55PM +0530, Pavankumar Kondeti wrote:
> > Function fs endpoint files does not have the notion of file position.
> > So switch to stream like functionality. This allows concurrent threads
> > to be blocked in the ffs read/write operations which use ffs_mutex_lock().
> > The ffs mutex lock deploys interruptible wait. Otherwise, threads are
> > blocking for the mutex lock in __fdget_pos(). For whatever reason, ff the
> > host does not send/receive data for longer time, hung task warnings
> > are observed.
> >
> > Change-Id: I602fa56fb5ed4c8c46e19df68c3335c4b12cae81
>
> Always run scripts/checkpatch.pl on your patches so you do not get
> grumpy maintainers asking you to run scripts/checkpatch.pl on them...
>
Thanks for taking a look at the patch. My bad, I have applied the patch
from a recent android tree and carry forwarded this tag. I will fix it.
Thanks,
Pavan
next prev parent reply other threads:[~2021-11-11 12:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 11:11 [PATCH] usb: gadget: f_fs: Use stream_open() for endpoint files Pavankumar Kondeti
2021-11-11 11:38 ` Greg Kroah-Hartman
2021-11-11 12:06 ` Pavan Kondeti [this message]
2021-11-11 12:15 ` [PATCH v2] " Pavankumar Kondeti
2021-11-11 13:12 ` Greg Kroah-Hartman
2021-11-12 3:17 ` Pavan Kondeti
2021-11-12 6:48 ` Greg Kroah-Hartman
2021-11-12 10:24 ` [PATCH v3] " Pavankumar Kondeti
2021-11-15 13:04 ` John Keeping
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211111120636.GA11612@hu-pkondeti-hyd.qualcomm.com \
--to=quic_pkondeti@quicinc.com \
--cc=andrew_gabbasov@mentor.com \
--cc=axboe@kernel.dk \
--cc=balbi@kernel.org \
--cc=dean@sensoray.com \
--cc=gregkh@linuxfoundation.org \
--cc=jackp@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lkp@intel.com \
--cc=peter.chen@nxp.com \
--cc=salah.triki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.