All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vishal Verma <vishal.l.verma@intel.com>
To: <linux-cxl@vger.kernel.org>
Cc: Dan Williams <dan.j.williams@intel.com>,
	Ben Widawsky <ben.widawsky@intel.com>, <nvdimm@lists.linux.dev>,
	Vishal Verma <vishal.l.verma@intel.com>
Subject: [ndctl PATCH v5 09/16] libcxl: add label_size to cxl_memdev, and an API to retrieve it
Date: Thu, 11 Nov 2021 13:44:29 -0700	[thread overview]
Message-ID: <20211111204436.1560365-10-vishal.l.verma@intel.com> (raw)
In-Reply-To: <20211111204436.1560365-1-vishal.l.verma@intel.com>

Size of the Label Storage Area (LSA) is available as a sysfs attribute
called 'label_storage_size'. Add that to libcxl's memdev so that it is available
for label related commands.

Cc: Dan Williams <dan.j.williams@intel.com>
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
---
 cxl/lib/private.h  |  1 +
 cxl/lib/libcxl.c   | 12 ++++++++++++
 cxl/libcxl.h       |  1 +
 cxl/lib/libcxl.sym |  1 +
 4 files changed, 15 insertions(+)

diff --git a/cxl/lib/private.h b/cxl/lib/private.h
index bf3a897..c4ed741 100644
--- a/cxl/lib/private.h
+++ b/cxl/lib/private.h
@@ -21,6 +21,7 @@ struct cxl_memdev {
 	unsigned long long pmem_size;
 	unsigned long long ram_size;
 	int payload_max;
+	size_t lsa_size;
 	struct kmod_module *module;
 };
 
diff --git a/cxl/lib/libcxl.c b/cxl/lib/libcxl.c
index 76913a2..def3a97 100644
--- a/cxl/lib/libcxl.c
+++ b/cxl/lib/libcxl.c
@@ -247,6 +247,13 @@ static void *add_cxl_memdev(void *parent, int id, const char *cxlmem_base)
 	if (memdev->payload_max < 0)
 		goto err_read;
 
+	sprintf(path, "%s/label_storage_size", cxlmem_base);
+	if (sysfs_read_attr(ctx, path, buf) < 0)
+		goto err_read;
+	memdev->lsa_size = strtoull(buf, NULL, 0);
+	if (memdev->lsa_size == ULLONG_MAX)
+		goto err_read;
+
 	memdev->dev_path = strdup(cxlmem_base);
 	if (!memdev->dev_path)
 		goto err_read;
@@ -350,6 +357,11 @@ CXL_EXPORT const char *cxl_memdev_get_firmware_verison(struct cxl_memdev *memdev
 	return memdev->firmware_version;
 }
 
+CXL_EXPORT size_t cxl_memdev_get_label_size(struct cxl_memdev *memdev)
+{
+	return memdev->lsa_size;
+}
+
 CXL_EXPORT void cxl_cmd_unref(struct cxl_cmd *cmd)
 {
 	if (!cmd)
diff --git a/cxl/libcxl.h b/cxl/libcxl.h
index 7408745..d3b97a1 100644
--- a/cxl/libcxl.h
+++ b/cxl/libcxl.h
@@ -42,6 +42,7 @@ struct cxl_ctx *cxl_memdev_get_ctx(struct cxl_memdev *memdev);
 unsigned long long cxl_memdev_get_pmem_size(struct cxl_memdev *memdev);
 unsigned long long cxl_memdev_get_ram_size(struct cxl_memdev *memdev);
 const char *cxl_memdev_get_firmware_verison(struct cxl_memdev *memdev);
+size_t cxl_memdev_get_label_size(struct cxl_memdev *memdev);
 
 #define cxl_memdev_foreach(ctx, memdev) \
         for (memdev = cxl_memdev_get_first(ctx); \
diff --git a/cxl/lib/libcxl.sym b/cxl/lib/libcxl.sym
index 629322c..858e953 100644
--- a/cxl/lib/libcxl.sym
+++ b/cxl/lib/libcxl.sym
@@ -64,6 +64,7 @@ global:
 	cxl_cmd_health_info_get_pmem_errors;
 	cxl_cmd_new_read_label;
 	cxl_cmd_read_label_get_payload;
+	cxl_memdev_get_label_size;
 local:
         *;
 };
-- 
2.31.1


  parent reply	other threads:[~2021-11-11 20:44 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-11 20:44 [ndctl PATCH v5 00/16] Initial CXL support Vishal Verma
2021-11-11 20:44 ` [ndctl PATCH v5 01/16] ndctl: add .clang-format Vishal Verma
2021-11-11 20:44 ` [ndctl PATCH v5 02/16] cxl: add a cxl utility and libcxl library Vishal Verma
2021-11-11 21:59   ` [ndctl PATCH v6 " Vishal Verma
2021-12-08  5:12   ` [ndctl PATCH v5 " Dan Williams
2021-12-09 20:23     ` [ndctl PATCH v6] " Vishal Verma
2021-12-09 20:40       ` Dan Williams
2021-12-09 21:09         ` [ndctl PATCH v7] " Vishal Verma
2021-12-09 21:23           ` Dan Williams
2021-11-11 20:44 ` [ndctl PATCH v5 03/16] cxl: add a local copy of the cxl_mem UAPI header Vishal Verma
2021-11-11 20:44 ` [ndctl PATCH v5 04/16] util: add the struct_size() helper from the kernel Vishal Verma
2022-01-31 11:47   ` Joao Martins
2021-11-11 20:44 ` [ndctl PATCH v5 05/16] libcxl: add support for command query and submission Vishal Verma
2021-11-11 20:44 ` [ndctl PATCH v5 06/16] libcxl: add support for the 'Identify Device' command Vishal Verma
2021-11-11 20:44 ` [ndctl PATCH v5 07/16] libcxl: add GET_HEALTH_INFO mailbox command and accessors Vishal Verma
2021-11-11 23:17   ` Dan Williams
2021-11-11 20:44 ` [ndctl PATCH v5 08/16] libcxl: add support for the 'GET_LSA' command Vishal Verma
2021-11-11 20:44 ` Vishal Verma [this message]
2021-11-11 20:44 ` [ndctl PATCH v5 10/16] libcxl: add representation for an nvdimm bridge object Vishal Verma
2021-11-11 23:49   ` Dan Williams
2021-11-12 21:53     ` Verma, Vishal L
2021-11-12 21:52   ` [ndctl PATCH v6 " Vishal Verma
2021-11-11 20:44 ` [ndctl PATCH v5 11/16] libcxl: add interfaces for label operations Vishal Verma
2021-11-11 20:44 ` [ndctl PATCH v5 12/16] cxl: add commands to read, write, and zero labels Vishal Verma
2021-11-11 20:44 ` [ndctl PATCH v5 13/16] Documentation/cxl: add library API documentation Vishal Verma
2021-11-11 20:44 ` [ndctl PATCH v5 14/16] ndctl: Add CXL packages to the RPM spec Vishal Verma
2021-11-11 20:44 ` [ndctl PATCH v5 15/16] cxl-cli: add bash completion Vishal Verma
2021-11-11 20:44 ` [ndctl PATCH v5 16/16] cxl: add health information to cxl-list Vishal Verma
2021-11-11 23:59   ` Dan Williams
2021-11-12 21:52   ` [ndctl PATCH v6 " Vishal Verma
2021-11-12 21:55     ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211111204436.1560365-10-vishal.l.verma@intel.com \
    --to=vishal.l.verma@intel.com \
    --cc=ben.widawsky@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=nvdimm@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.