From: Jonathan Cameron <jic23@kernel.org>
To: linux-iio@vger.kernel.org, Nuno Sa <Nuno.Sa@analog.com>
Cc: Marcelo Schmitt <marcelo.schmitt1@gmail.com>,
lars@metafoo.de, Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: [PATCH v2 00/17] iio:adc:ad7280a Cleanup and proposed staging graduation.
Date: Sun, 5 Dec 2021 20:26:53 +0000 [thread overview]
Message-ID: <20211205202710.2847005-1-jic23@kernel.org> (raw)
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
v2: Picked up Rob's tag for the binding
Rebase and a trivial white space tidy up.
Marcelo expressed interest in reviewing this one, but given it's
been a while I'm resending in the hope that someone else will have
time to take a look. Obviously if anyone wants to try the emulation
that's great but fundamental thing I'm looking for here is review of
the final patch as that has the whole driver in it.
Note we don't require perfection for staging graduations, so futher
cleanup can be delayed until it's out of staging.
The interesting stuff here is anything related to the ABI as that
is pretty much fixed once it's out of staging. Obviously any
feedback welcome.
v1 cover letter.
Hi All,
This one proved an interesting diversion.
Work done against a somewhat hacked up QEMU emulation of 3 daisy chained
ad7280a devices (18 channels). Note that the emulation isn't complete
but does do chaining, CRC, and readout of channels etc in a fashion that
worked with the original driver (up to the bug in patch 1) and continues
to work with the updated version. I've not intention to upstream the
emulation (as would need to make it more completed and flexible), but
happy to share it with anyone who is interested.
I briefly flirted with posting a patch to just drop the driver entirely,
but the part is still available and it looked like fun + isn't going
to greatly impact maintainability of the subsystem long term so is low
cost even if it goes obsolete sometime soonish.
There are lots of things we could do after this set to improved the driver
and make things more flexible, but it should basically 'just work'
Anyhow, as normal for staging graduations, last patch has rename detection
turned off so that people can easily see what I am proposing we move
out of staging.
Jonathan Cameron (17):
staging:iio:adc:ad7280a: Fix handing of device address bit reversing.
staging:iio:adc:ad7280a: Register define cleanup.
staging:iio:adc:ad7280a: rename _read() to _read_reg()
staging:iio:adc:ad7280a: Split buff[2] into tx and rx parts
staging:iio:adc:ad7280a: Use bitfield ops to managed fields in
transfers.
staging:iio:adc:ad7280a: Switch to standard event control
staging:iio:adc:ad7280a: Standardize extended ABI naming
staging:iio:adc:ad7280a: Drop unused timestamp channel.
staging:iio:adc:ad7280a: Trivial comment formatting cleanup
staging:iio:adc:ad7280a: Make oversampling_ratio a runtime control
staging:iio:adc:ad7280a: Cleanup includes
staging:iio:ad7280a: Reflect optionality of irq in ABI
staging:iio:adc:ad7280a: Use a local dev pointer to avoid &spi->dev
staging:iio:adc:ad7280a: Use device properties to replace platform
data.
dt-bindings:iio:adc:ad7280a: Add binding
iio:adc:ad7280a: Document ABI for cell balance switches
iio:adc:ad7280a: Move out of staging
.../ABI/testing/sysfs-bus-iio-adc-ad7280a | 13 +
.../bindings/iio/adc/adi,ad7280a.yaml | 87 ++
drivers/iio/adc/Kconfig | 11 +
drivers/iio/adc/Makefile | 1 +
drivers/iio/adc/ad7280a.c | 1116 +++++++++++++++++
drivers/staging/iio/adc/Kconfig | 11 -
drivers/staging/iio/adc/Makefile | 1 -
drivers/staging/iio/adc/ad7280a.c | 1044 ---------------
drivers/staging/iio/adc/ad7280a.h | 37 -
9 files changed, 1228 insertions(+), 1093 deletions(-)
create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-adc-ad7280a
create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7280a.yaml
create mode 100644 drivers/iio/adc/ad7280a.c
delete mode 100644 drivers/staging/iio/adc/ad7280a.c
delete mode 100644 drivers/staging/iio/adc/ad7280a.h
--
2.34.1
next reply other threads:[~2021-12-05 20:22 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-05 20:26 Jonathan Cameron [this message]
2021-12-05 20:26 ` [PATCH v2 01/17] staging:iio:adc:ad7280a: Fix handing of device address bit reversing Jonathan Cameron
2021-12-13 12:26 ` Marcelo Schmitt
2021-12-05 20:26 ` [PATCH v2 02/17] staging:iio:adc:ad7280a: Register define cleanup Jonathan Cameron
2021-12-13 12:41 ` Marcelo Schmitt
2022-02-06 17:01 ` Jonathan Cameron
2021-12-05 20:26 ` [PATCH v2 03/17] staging:iio:adc:ad7280a: rename _read() to _read_reg() Jonathan Cameron
2021-12-14 17:05 ` Marcelo Schmitt
2021-12-05 20:26 ` [PATCH v2 04/17] staging:iio:adc:ad7280a: Split buff[2] into tx and rx parts Jonathan Cameron
2021-12-14 17:05 ` Marcelo Schmitt
2021-12-05 20:26 ` [PATCH v2 05/17] staging:iio:adc:ad7280a: Use bitfield ops to managed fields in transfers Jonathan Cameron
2021-12-14 17:12 ` Marcelo Schmitt
2022-02-06 17:14 ` Jonathan Cameron
2022-02-06 18:02 ` Marcelo Schmitt
2021-12-05 20:26 ` [PATCH v2 06/17] staging:iio:adc:ad7280a: Switch to standard event control Jonathan Cameron
2021-12-14 17:41 ` Marcelo Schmitt
2022-02-06 17:34 ` Jonathan Cameron
2021-12-05 20:27 ` [PATCH v2 07/17] staging:iio:adc:ad7280a: Standardize extended ABI naming Jonathan Cameron
2021-12-18 20:17 ` Marcelo Schmitt
2021-12-05 20:27 ` [PATCH v2 08/17] staging:iio:adc:ad7280a: Drop unused timestamp channel Jonathan Cameron
2021-12-18 20:18 ` Marcelo Schmitt
2021-12-05 20:27 ` [PATCH v2 09/17] staging:iio:adc:ad7280a: Trivial comment formatting cleanup Jonathan Cameron
2021-12-18 20:21 ` Marcelo Schmitt
2021-12-05 20:27 ` [PATCH v2 10/17] staging:iio:adc:ad7280a: Make oversampling_ratio a runtime control Jonathan Cameron
2021-12-18 20:22 ` Marcelo Schmitt
2021-12-05 20:27 ` [PATCH v2 11/17] staging:iio:adc:ad7280a: Cleanup includes Jonathan Cameron
2021-12-18 20:22 ` Marcelo Schmitt
2021-12-05 20:27 ` [PATCH v2 12/17] staging:iio:ad7280a: Reflect optionality of irq in ABI Jonathan Cameron
2021-12-18 20:30 ` Marcelo Schmitt
2022-01-30 20:05 ` Jonathan Cameron
2021-12-05 20:27 ` [PATCH v2 13/17] staging:iio:adc:ad7280a: Use a local dev pointer to avoid &spi->dev Jonathan Cameron
2021-12-18 20:31 ` Marcelo Schmitt
2021-12-05 20:27 ` [PATCH v2 14/17] staging:iio:adc:ad7280a: Use device properties to replace platform data Jonathan Cameron
2021-12-18 21:06 ` Marcelo Schmitt
2022-01-30 20:24 ` Jonathan Cameron
2022-02-06 18:06 ` Jonathan Cameron
2021-12-05 20:27 ` [PATCH v2 15/17] dt-bindings:iio:adc:ad7280a: Add binding Jonathan Cameron
2021-12-18 21:18 ` Marcelo Schmitt
2022-01-30 20:29 ` Jonathan Cameron
2022-02-06 2:31 ` Marcelo Schmitt
2022-02-06 18:13 ` Jonathan Cameron
2021-12-05 20:27 ` [PATCH v2 16/17] iio:adc:ad7280a: Document ABI for cell balance switches Jonathan Cameron
2021-12-18 21:20 ` Marcelo Schmitt
2021-12-05 20:27 ` [PATCH v2 17/17] iio:adc:ad7280a: Move out of staging Jonathan Cameron
2021-12-18 22:08 ` Marcelo Schmitt
2022-01-30 20:46 ` Jonathan Cameron
2022-02-06 18:45 ` Jonathan Cameron
2021-12-13 12:51 ` [PATCH v2 00/17] iio:adc:ad7280a Cleanup and proposed staging graduation Marcelo Schmitt
2021-12-16 11:46 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211205202710.2847005-1-jic23@kernel.org \
--to=jic23@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=Nuno.Sa@analog.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=marcelo.schmitt1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.