From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, broonie@kernel.org,
"Péter Ujfalusi" <peter.ujfalusi@linux.intel.com>,
"Pierre-Louis Bossart" <pierre-louis.bossart@linux.intel.com>,
"Ranjani Sridharan" <ranjani.sridharan@linux.intel.com>
Subject: [PATCH 3/7] ASoC: SOF: Intel: hda-ctrl: apply symmetry for DPIB
Date: Tue, 7 Dec 2021 13:39:43 -0600 [thread overview]
Message-ID: <20211207193947.71080-4-pierre-louis.bossart@linux.intel.com> (raw)
In-Reply-To: <20211207193947.71080-1-pierre-louis.bossart@linux.intel.com>
we use 'bus->use_posbuf && bus->posbuf.addr' in
hda_dsp_ctrl_init_chip(), use the same for hda_dsp_ctrl_stop_chip()
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
---
sound/soc/sof/intel/hda-ctrl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/sof/intel/hda-ctrl.c b/sound/soc/sof/intel/hda-ctrl.c
index fa5f0a718901..0c29bb196e59 100644
--- a/sound/soc/sof/intel/hda-ctrl.c
+++ b/sound/soc/sof/intel/hda-ctrl.c
@@ -353,7 +353,7 @@ void hda_dsp_ctrl_stop_chip(struct snd_sof_dev *sdev)
snd_hdac_bus_stop_cmd_io(bus);
#endif
/* disable position buffer */
- if (bus->posbuf.addr) {
+ if (bus->use_posbuf && bus->posbuf.addr) {
snd_sof_dsp_write(sdev, HDA_DSP_HDA_BAR,
SOF_HDA_ADSP_DPLBASE, 0);
snd_sof_dsp_write(sdev, HDA_DSP_HDA_BAR,
--
2.25.1
next prev parent reply other threads:[~2021-12-07 19:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 19:39 [PATCH 0/7] ASoC: Intel: SOF: clarifications on hardware support Pierre-Louis Bossart
2021-12-07 19:39 ` [PATCH 1/7] ASoC: SOF: Intel: ICL: move ICL-specific ops to icl.c Pierre-Louis Bossart
2021-12-07 19:39 ` [PATCH 2/7] ASoC: SOF: Intel: hda-stream: limit PROCEN workaround Pierre-Louis Bossart
2021-12-07 19:39 ` Pierre-Louis Bossart [this message]
2021-12-07 19:39 ` [PATCH 4/7] ASoC: SOF: hda-stream: only enable DPIB if needed Pierre-Louis Bossart
2021-12-07 19:39 ` [PATCH 5/7] ASoC: SOF: Intel: hda: add quirks for HDAudio DMA position information Pierre-Louis Bossart
2021-12-07 19:39 ` [PATCH 6/7] ASoC: SOF: Intel: hda-dai: remove unused fields Pierre-Louis Bossart
2021-12-07 19:39 ` [PATCH 7/7] ASoC: SOF: Intel: add comment on JasperLake support Pierre-Louis Bossart
2021-12-13 22:42 ` [PATCH 0/7] ASoC: Intel: SOF: clarifications on hardware support Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211207193947.71080-4-pierre-louis.bossart@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=peter.ujfalusi@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.