From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: Kees Cook <keescook@chromium.org>
Cc: tools@linux.kernel.org
Subject: Re: [PATCH 1/2] patchwork-bot: Ignore empty context lines
Date: Fri, 17 Dec 2021 11:17:44 -0500 [thread overview]
Message-ID: <20211217161744.rxvsw2wwqzseowao@meerkat.local> (raw)
In-Reply-To: <202112161410.FCEC1C1189@keescook>
On Thu, Dec 16, 2021 at 02:11:08PM -0800, Kees Cook wrote:
> > $ MSGID=20210911102818.3804-1-len.baker@gmx.com
> > $ wget -qO- https://patchwork.kernel.org/project/linux-hardening/patch/$MSGID/raw/ | \
> > grep '^ $' | wc -l
> > 0
> >
> > $ SHA=f11ee2ad25b22c2ee587045dd6999434375532f7
> > $ git diff ${SHA}~..${SHA} | \
> > grep '^ $' | wc -l
> > 2
> >
> > Teaching patchwork-bot to ignore empty context lines allows pwhashes to
> > match in these cases, which lets those patches get located again.
>
> With regard to the revert, do you not see the above problem with your
> repos? I'm working against the same patchwork. I guess there is some
> other root cause?
I'm curious if you have local git configs that affect your "git diff" output.
If you "export GIT_CONFIG_GLOBAL=/dev/null", does this make any difference to
your experience?
-K
next prev parent reply other threads:[~2021-12-17 16:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 23:38 [PATCH 0/2] patchwork-bot: Ignore empty context lines Kees Cook
2021-12-02 23:38 ` [PATCH 1/2] " Kees Cook
2021-12-16 22:11 ` Kees Cook
2021-12-17 16:17 ` Konstantin Ryabitsev [this message]
2021-12-17 16:41 ` Kees Cook
2021-12-17 17:21 ` Konstantin Ryabitsev
2021-12-02 23:38 ` [PATCH 2/2] patchwork-bot: Add --pwhash for debugging Kees Cook
2021-12-13 22:30 ` [PATCH 0/2] patchwork-bot: Ignore empty context lines Konstantin Ryabitsev
2021-12-16 20:23 ` Konstantin Ryabitsev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211217161744.rxvsw2wwqzseowao@meerkat.local \
--to=konstantin@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=tools@linux.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.