All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liam Beguin <liambeguin@gmail.com>
To: liambeguin@gmail.com, peda@axentia.se, jic23@kernel.org,
	andy.shevchenko@gmail.com, lars@metafoo.de
Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
	devicetree@vger.kernel.org, robh+dt@kernel.org
Subject: [PATCH v11 06/15] iio: afe: rescale: add offset support
Date: Tue, 21 Dec 2021 22:46:37 -0500	[thread overview]
Message-ID: <20211222034646.222189-7-liambeguin@gmail.com> (raw)
In-Reply-To: <20211222034646.222189-1-liambeguin@gmail.com>

From: Liam Beguin <lvb@xiphos.com>

This is a preparatory change required for the addition of temperature
sensing front ends.

Signed-off-by: Liam Beguin <lvb@xiphos.com>
---
 drivers/iio/afe/iio-rescale.c   | 80 +++++++++++++++++++++++++++++++++
 include/linux/iio/afe/rescale.h |  4 ++
 2 files changed, 84 insertions(+)

diff --git a/drivers/iio/afe/iio-rescale.c b/drivers/iio/afe/iio-rescale.c
index 190a83e08008..6a2d4ae80652 100644
--- a/drivers/iio/afe/iio-rescale.c
+++ b/drivers/iio/afe/iio-rescale.c
@@ -81,11 +81,46 @@ int rescale_process_scale(struct rescale *rescale, int scale_type,
 	}
 }
 
+int rescale_process_offset(struct rescale *rescale, int scale_type,
+			   int scale, int scale2, int schan_off,
+			   int *val, int *val2)
+{
+	s64 tmp, tmp2;
+
+	switch (scale_type) {
+	case IIO_VAL_FRACTIONAL:
+		tmp = (s64)rescale->offset * scale2;
+		*val = div_s64(tmp, scale) + schan_off;
+		return IIO_VAL_INT;
+	case IIO_VAL_INT:
+		*val = div_s64(rescale->offset, scale) + schan_off;
+		return IIO_VAL_INT;
+	case IIO_VAL_FRACTIONAL_LOG2:
+		tmp = (s64)rescale->offset * (1 << scale2);
+		*val = div_s64(tmp, scale) + schan_off;
+		return IIO_VAL_INT;
+	case IIO_VAL_INT_PLUS_NANO:
+		tmp = (s64)rescale->offset * NANO;
+		tmp2 = ((s64)scale * NANO) + scale2;
+		*val = div64_s64(tmp, tmp2) + schan_off;
+		return IIO_VAL_INT;
+	case IIO_VAL_INT_PLUS_MICRO:
+		tmp = (s64)rescale->offset * MICRO;
+		tmp2 = ((s64)scale * MICRO) + scale2;
+		*val = div64_s64(tmp, tmp2) + schan_off;
+		return IIO_VAL_INT;
+	default:
+		return -EOPNOTSUPP;
+	}
+}
+
 static int rescale_read_raw(struct iio_dev *indio_dev,
 			    struct iio_chan_spec const *chan,
 			    int *val, int *val2, long mask)
 {
 	struct rescale *rescale = iio_priv(indio_dev);
+	int scale, scale2;
+	int schan_off = 0;
 	int ret;
 
 	switch (mask) {
@@ -112,6 +147,47 @@ static int rescale_read_raw(struct iio_dev *indio_dev,
 			ret = iio_read_channel_scale(rescale->source, val, val2);
 		}
 		return rescale_process_scale(rescale, ret, val, val2);
+	case IIO_CHAN_INFO_OFFSET:
+		/*
+		 * Processed channels are scaled 1-to-1 and source offset is
+		 * already taken into account.
+		 *
+		 * In other cases, real world measurement are expressed as:
+		 *
+		 *	schan_scale * (raw + schan_offset)
+		 *
+		 * Given that the rescaler parameters are applied recursively:
+		 *
+		 *	rescaler_scale * (schan_scale * (raw + schan_offset) +
+		 *		rescaler_offset)
+		 *
+		 * Or,
+		 *
+		 *	(rescaler_scale * schan_scale) * (raw +
+		 *		(schan_offset +	rescaler_offset / schan_scale)
+		 *
+		 * Thus, reusing the original expression the parameters exposed
+		 * to userspace are:
+		 *
+		 *	scale = schan_scale * rescaler_scale
+		 *	offset = schan_offset + rescaler_offset / schan_scale
+		 */
+		if (rescale->chan_processed) {
+			*val = rescale->offset;
+			return IIO_VAL_INT;
+		}
+
+		if (iio_channel_has_info(rescale->source->channel,
+					 IIO_CHAN_INFO_OFFSET)) {
+			ret = iio_read_channel_offset(rescale->source,
+						      &schan_off, NULL);
+			if (ret != IIO_VAL_INT)
+				return ret < 0 ? ret : -EOPNOTSUPP;
+		}
+
+		ret = iio_read_channel_scale(rescale->source, &scale, &scale2);
+		return rescale_process_offset(rescale, ret, scale, scale2,
+					      schan_off, val, val2);
 	default:
 		return -EINVAL;
 	}
@@ -188,6 +264,9 @@ static int rescale_configure_channel(struct device *dev,
 	chan->info_mask_separate = BIT(IIO_CHAN_INFO_RAW) |
 		BIT(IIO_CHAN_INFO_SCALE);
 
+	if (rescale->offset)
+		chan->info_mask_separate |= BIT(IIO_CHAN_INFO_OFFSET);
+
 	/*
 	 * Using .read_avail() is fringe to begin with and makes no sense
 	 * whatsoever for processed channels, so we make sure that this cannot
@@ -352,6 +431,7 @@ static int rescale_probe(struct platform_device *pdev)
 	rescale->cfg = of_device_get_match_data(dev);
 	rescale->numerator = 1;
 	rescale->denominator = 1;
+	rescale->offset = 0;
 
 	ret = rescale->cfg->props(dev, rescale);
 	if (ret)
diff --git a/include/linux/iio/afe/rescale.h b/include/linux/iio/afe/rescale.h
index 14d4ee1227c6..b152ac487403 100644
--- a/include/linux/iio/afe/rescale.h
+++ b/include/linux/iio/afe/rescale.h
@@ -23,8 +23,12 @@ struct rescale {
 	bool chan_processed;
 	s32 numerator;
 	s32 denominator;
+	s32 offset;
 };
 
 int rescale_process_scale(struct rescale *rescale, int scale_type,
 			  int *val, int *val2);
+int rescale_process_offset(struct rescale *rescale, int scale_type,
+			   int scale, int scale2, int schan_off,
+			   int *val, int *val2);
 #endif /* __IIO_RESCALE_H__ */
-- 
2.34.0


  parent reply	other threads:[~2021-12-22  3:47 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-22  3:46 [PATCH v11 00/15] iio: afe: add temperature rescaling support Liam Beguin
2021-12-22  3:46 ` [PATCH v11 01/15] iio: inkern: apply consumer scale on IIO_VAL_INT cases Liam Beguin
2021-12-22  3:46 ` [PATCH v11 02/15] iio: inkern: apply consumer scale when no channel scale is available Liam Beguin
2021-12-22  3:46 ` [PATCH v11 03/15] iio: inkern: make a best effort on offset calculation Liam Beguin
2021-12-22  3:46 ` [PATCH v11 04/15] iio: afe: rescale: expose scale processing function Liam Beguin
2021-12-22 10:21   ` Andy Shevchenko
2021-12-22 18:20     ` Liam Beguin
2021-12-22 18:52       ` Andy Shevchenko
2021-12-22 19:42         ` Liam Beguin
2021-12-22 19:50           ` Andy Shevchenko
2021-12-22 20:04             ` Liam Beguin
2021-12-22  3:46 ` [PATCH v11 05/15] iio: afe: rescale: add INT_PLUS_{MICRO,NANO} support Liam Beguin
2021-12-22  3:46 ` Liam Beguin [this message]
2021-12-22  3:46 ` [PATCH v11 07/15] iio: afe: rescale: use s64 for temporary scale calculations Liam Beguin
2021-12-22 12:25   ` Andy Shevchenko
2021-12-22 18:21     ` Liam Beguin
2021-12-22  3:46 ` [PATCH v11 08/15] iio: afe: rescale: fix accuracy for small fractional scales Liam Beguin
2021-12-22 12:27   ` Andy Shevchenko
2021-12-22  3:46 ` [PATCH v11 09/15] iio: afe: rescale: reduce risk of integer overflow Liam Beguin
2021-12-22 12:29   ` Andy Shevchenko
2021-12-22 18:38     ` Liam Beguin
2021-12-22 18:56       ` Andy Shevchenko
2021-12-22 19:58         ` Liam Beguin
2021-12-22 21:32           ` Andy Shevchenko
2022-01-08 16:34             ` Liam Beguin
2022-01-08 17:55               ` Andy Shevchenko
2021-12-22  3:46 ` [PATCH v11 10/15] iio: afe: rescale: make use of units.h Liam Beguin
2021-12-22 12:33   ` Andy Shevchenko
2021-12-22 18:50     ` Liam Beguin
2021-12-22 18:59       ` Andy Shevchenko
2021-12-22  3:46 ` [PATCH v11 11/15] iio: test: add basic tests for the iio-rescale driver Liam Beguin
2021-12-22 12:38   ` Andy Shevchenko
2021-12-22 19:13     ` Liam Beguin
2021-12-22  3:46 ` [PATCH v11 12/15] iio: afe: rescale: add RTD temperature sensor support Liam Beguin
2021-12-22  3:46 ` [PATCH v11 13/15] iio: afe: rescale: add temperature transducers Liam Beguin
2021-12-22 12:40   ` Andy Shevchenko
2021-12-22  3:46 ` [PATCH v11 14/15] dt-bindings: iio: afe: add bindings for temperature-sense-rtd Liam Beguin
2021-12-22  3:46 ` [PATCH v11 15/15] dt-bindings: iio: afe: add bindings for temperature transducers Liam Beguin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211222034646.222189-7-liambeguin@gmail.com \
    --to=liambeguin@gmail.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peda@axentia.se \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.