From: Guenter Roeck <linux@roeck-us.net>
To: Jackie Liu <liu.yun@linux.dev>
Cc: martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
hch@lst.de, axboe@kernel.dk
Subject: Re: [PATCH v2] scsi: bsg: fix errno when scsi_bsg_register_queue fails
Date: Wed, 22 Dec 2021 08:54:35 -0800 [thread overview]
Message-ID: <20211222165435.GA283263@roeck-us.net> (raw)
In-Reply-To: <20211022010201.426746-1-liu.yun@linux.dev>
On Fri, Oct 22, 2021 at 09:02:01AM +0800, Jackie Liu wrote:
> From: Jackie Liu <liuyun01@kylinos.cn>
>
> When the value of error is printed, it will always be 0. Here, we should be
> print the correct error code when scsi_bsg_register_queue fails.
>
The comment above the changed code says:
"
We're treating error on bsg register as non-fatal, so pretend nothing went wrong.
"
With this patch in place, "error" is returned to the caller, and the code
no longer pretends that nothing is wrong. Also, the message is a dev_info
message, not dev_err, suggesting that ignoring the error was indeed on
purpose. Assuming the comment is correct, this patch is plain wrong;
the message should have printed PTR_ERR(sdev->bsg_dev) instead and not set
the 'error' variable.
Guenter
> Fixes: ead09dd3aed5 ("scsi: bsg: Simplify device registration")
> Cc: Jens Axboe <axboe@kernel.dk>
> Cc: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Jackie Liu <liuyun01@kylinos.cn>
> ---
> v1->v2:
> resend to linux-scsi mail list.
>
> drivers/scsi/scsi_sysfs.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
> index 86793259e541..d8789f6cda62 100644
> --- a/drivers/scsi/scsi_sysfs.c
> +++ b/drivers/scsi/scsi_sysfs.c
> @@ -1379,6 +1379,7 @@ int scsi_sysfs_add_sdev(struct scsi_device *sdev)
> * We're treating error on bsg register as non-fatal, so
> * pretend nothing went wrong.
> */
> + error = PTR_ERR(sdev->bsg_dev);
> sdev_printk(KERN_INFO, sdev,
> "Failed to register bsg queue, errno=%d\n",
> error);
> --
> 2.25.1
>
next prev parent reply other threads:[~2021-12-22 16:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-22 1:02 [PATCH v2] scsi: bsg: fix errno when scsi_bsg_register_queue fails Jackie Liu
2021-12-22 16:54 ` Guenter Roeck [this message]
2021-12-23 1:07 ` Jackie Liu
2021-12-23 1:35 ` Guenter Roeck
2021-12-23 2:42 ` Jackie Liu
2021-12-23 3:13 ` Jackie Liu
2021-12-23 6:33 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211222165435.GA283263@roeck-us.net \
--to=linux@roeck-us.net \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
--cc=liu.yun@linux.dev \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.