Re: [PATCH v3 8/8] i2c: i801: convert to use common P2SB accessor

From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v3 8/8] i2c: i801: convert to use common P2SB accessor
Date: Thu, 23 Dec 2021 02:10:34 +0800	[thread overview]
Message-ID: <202112230228.K90y568j-lkp@intel.com> (raw)
In-Reply-To: <20211221181526.53798-9-andriy.shevchenko@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 3307 bytes --]

Hi Andy,

I love your patch! Yet something to improve:

[auto build test ERROR on wsa/i2c/for-next]
[also build test ERROR on linus/master v5.16-rc6 next-20211222]
[cannot apply to lee-mfd/for-mfd-next helgaas-pci/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Andy-Shevchenko/platform-x86-introduce-p2sb_bar-helper/20211222-022450
base:   https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next
config: i386-randconfig-a001-20211220 (https://download.01.org/0day-ci/archive/20211223/202112230228.K90y568j-lkp(a)intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/831fa02e19dbf5ed40c173bc97a1cef1bdfb2d90
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Andy-Shevchenko/platform-x86-introduce-p2sb_bar-helper/20211222-022450
        git checkout 831fa02e19dbf5ed40c173bc97a1cef1bdfb2d90
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   ld: drivers/mfd/lpc_ich.o: in function `lpc_ich_init_pinctrl':
   drivers/mfd/lpc_ich.c:1162: undefined reference to `p2sb_bar'
   ld: drivers/mfd/lpc_ich.o: in function `lpc_ich_init_spi':
   drivers/mfd/lpc_ich.c:1230: undefined reference to `p2sb_bar'
   ld: drivers/i2c/busses/i2c-i801.o: in function `i801_add_tco_spt':
>> drivers/i2c/busses/i2c-i801.c:1485: undefined reference to `p2sb_bar'

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for P2SB
   Depends on X86 && X86_PLATFORM_DEVICES && X86_PLATFORM_DRIVERS_INTEL && PCI
   Selected by
   - I2C_I801 && I2C && HAS_IOMEM && PCI && X86
   - LPC_ICH && HAS_IOMEM && PCI && X86

vim +1485 drivers/i2c/busses/i2c-i801.c

  1467	
  1468	static struct platform_device *
  1469	i801_add_tco_spt(struct i801_priv *priv, struct pci_dev *pci_dev,
  1470			 struct resource *tco_res)
  1471	{
  1472		static const struct itco_wdt_platform_data pldata = {
  1473			.name = "Intel PCH",
  1474			.version = 4,
  1475		};
  1476		struct resource *res;
  1477		int ret;
  1478	
  1479		/*
  1480		 * We must access the NO_REBOOT bit over the Primary to Sideband
  1481		 * (P2SB) bridge.
  1482		 */
  1483	
  1484		res = &tco_res[1];
> 1485		ret = p2sb_bar(pci_dev->bus, 0, res);
  1486		if (ret)
  1487			return ERR_PTR(ret);
  1488	
  1489		if (pci_dev->device == PCI_DEVICE_ID_INTEL_DNV_SMBUS)
  1490			res->start += SBREG_SMBCTRL_DNV;
  1491		else
  1492			res->start += SBREG_SMBCTRL;
  1493	
  1494		res->end = res->start + 3;
  1495	
  1496		return platform_device_register_resndata(&pci_dev->dev, "iTCO_wdt", -1,
  1497						tco_res, 2, &pldata, sizeof(pldata));
  1498	}
  1499	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org