From: Jakub Kicinski <kuba@kernel.org>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Jianguo Wu <wujianguo106@163.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] selftests/net: udpgso_bench_tx: fix dst ip argument
Date: Wed, 29 Dec 2021 18:25:14 -0800 [thread overview]
Message-ID: <20211229182514.54892af9@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> (raw)
In-Reply-To: <CA+FuTSfFmgwvLfkvk0knA0G7mbuKw3PdX=M9AAhLjxKuUYEO+g@mail.gmail.com>
On Wed, 29 Dec 2021 09:16:37 -0500 Willem de Bruijn wrote:
> On Wed, Dec 29, 2021 at 5:58 AM Jianguo Wu <wujianguo106@163.com> wrote:
> >
> > From: wujianguo <wujianguo@chinatelecom.cn>
> >
> > udpgso_bench_tx call setup_sockaddr() for dest address before
> > parsing all arguments, if we specify "-p ${dst_port}" after "-D ${dst_ip}",
> > then ${dst_port} will be ignored, and using default cfg_port 8000.
> >
> > This will cause test case "multiple GRO socks" failed in udpgro.sh.
> >
> > Setup sockaddr after after parsing all arguments.
s/after after/after/
> >
> > Fixes: 3a687bef148d ("selftests: udp gso benchmark")
> > Signed-off-by: Jianguo Wu <wujianguo@chinatelecom.cn>
>
> Reviewed-by: Willem de Bruijn <willemb@google.com>
>
> The udpgso_bench_tx equivalent to commit d336509cb9d0 ("selftests/net:
> udpgso_bench_rx: fix port argument"). Thanks.
Applied, thanks!
prev parent reply other threads:[~2021-12-30 2:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-29 10:58 [PATCH] selftests/net: udpgso_bench_tx: fix dst ip argument Jianguo Wu
2021-12-29 14:16 ` Willem de Bruijn
2021-12-30 2:25 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211229182514.54892af9@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net \
--to=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=willemdebruijn.kernel@gmail.com \
--cc=wujianguo106@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.