Re: [PATCH] fixup! PCI: brcmstb: Add control of subdevice voltage regulators

From: Bjorn Helgaas <helgaas@kernel.org>
To: Jim Quinlan <jim2101024@gmail.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	james.quinlan@broadcom.com, linux-pci@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH] fixup! PCI: brcmstb: Add control of subdevice voltage regulators
Date: Wed, 12 Jan 2022 11:51:06 -0600	[thread overview]
Message-ID: <20220112175106.GA267550@bhelgaas> (raw)
In-Reply-To: <20220112013100.48029-1-jim2101024@gmail.com>

On Tue, Jan 11, 2022 at 08:31:00PM -0500, Jim Quinlan wrote:

What's this connected to?  Is this a fix for a patch that has already
been merged?  If so, which one?  If it's a standalone thing, it needs
a commit log and a Signed-off-by.  Actually, that would be good in any
case.  Maybe a lore link to the relevant patch?

> ---
>  drivers/pci/controller/pcie-brcmstb.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c
> index 8a3321314b74..4134f01acd87 100644
> --- a/drivers/pci/controller/pcie-brcmstb.c
> +++ b/drivers/pci/controller/pcie-brcmstb.c
> @@ -1392,7 +1392,8 @@ static int brcm_pcie_resume(struct device *dev)
>  err_reset:
>  	reset_control_rearm(pcie->rescal);
>  err_regulator:
> -	regulator_bulk_disable(pcie->sr->num_supplies, pcie->sr->supplies);
> +	if (pcie->sr)
> +		regulator_bulk_disable(pcie->sr->num_supplies, pcie->sr->supplies);
>  err_disable_clk:
>  	clk_disable_unprepare(pcie->clk);
>  	return ret;
> -- 
> 2.17.1
> 