From: Jacopo Mondi <jacopo@jmondi.org>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Cc: linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
"Kieran Bingham" <kieran.bingham@ideasonboard.com>,
"Niklas Söderlund" <niklas.soderlund@ragnatech.se>
Subject: Re: [PATCH] media: i2c: max9286: Implement media entity .link_validate() operation
Date: Fri, 14 Jan 2022 09:19:31 +0100 [thread overview]
Message-ID: <20220114081931.3b6yugropjmboxnr@uno.localdomain> (raw)
In-Reply-To: <20220113205150.6533-1-laurent.pinchart+renesas@ideasonboard.com>
Hi Laurent,
On Thu, Jan 13, 2022 at 10:51:50PM +0200, Laurent Pinchart wrote:
> The MAX9286 has sink pads, so it should implement .link_validate(). Do
> so.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Indeed
Reviewed-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
Thanks
j
> ---
> drivers/media/i2c/max9286.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c
> index eb2b8e42335b..b4885d3b3059 100644
> --- a/drivers/media/i2c/max9286.c
> +++ b/drivers/media/i2c/max9286.c
> @@ -846,6 +846,10 @@ static const struct v4l2_subdev_internal_ops max9286_subdev_internal_ops = {
> .open = max9286_open,
> };
>
> +static const struct media_entity_operations max9286_media_ops = {
> + .link_validate = v4l2_subdev_link_validate
> +};
> +
> static int max9286_s_ctrl(struct v4l2_ctrl *ctrl)
> {
> switch (ctrl->id) {
> @@ -895,6 +899,7 @@ static int max9286_v4l2_register(struct max9286_priv *priv)
> goto err_async;
>
> priv->sd.entity.function = MEDIA_ENT_F_VID_IF_BRIDGE;
> + priv->sd.entity.ops = &max9286_media_ops;
>
> priv->pads[MAX9286_SRC_PAD].flags = MEDIA_PAD_FL_SOURCE;
> for (i = 0; i < MAX9286_SRC_PAD; i++)
> --
> Regards,
>
> Laurent Pinchart
>
next prev parent reply other threads:[~2022-01-14 8:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-13 20:51 [PATCH] media: i2c: max9286: Implement media entity .link_validate() operation Laurent Pinchart
2022-01-14 8:19 ` Jacopo Mondi [this message]
2022-01-26 9:54 ` Kieran Bingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220114081931.3b6yugropjmboxnr@uno.localdomain \
--to=jacopo@jmondi.org \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=niklas.soderlund@ragnatech.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.