Re: [RFC][PATCH v2 1/5] mm: Avoid unmapping pinned pages

From: Peter Zijlstra <peterz@infradead.org>
To: Nadav Amit <nadav.amit@gmail.com>
Cc: Ingo Molnar <mingo@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	juri.lelli@redhat.com, vincent.guittot@linaro.org,
	dietmar.eggemann@arm.com, Steven Rostedt <rostedt@goodmis.org>,
	bsegall@google.com, Mel Gorman <mgorman@suse.de>,
	bristot@redhat.com,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux-MM <linux-mm@kvack.org>,
	linux-api@vger.kernel.org, X86 ML <x86@kernel.org>,
	pjt@google.com, posk@google.com, avagin@google.com,
	Jann Horn <jannh@google.com>,
	tdelisle@uwaterloo.ca, mark.rutland@arm.com, posk@posk.io
Subject: Re: [RFC][PATCH v2 1/5] mm: Avoid unmapping pinned pages
Date: Fri, 21 Jan 2022 08:59:43 +0100	[thread overview]
Message-ID: <20220121075943.GB20638@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <E63F4045-E624-47FE-A417-5D2FF7923179@gmail.com>

On Thu, Jan 20, 2022 at 10:03:44AM -0800, Nadav Amit wrote:

> > --- a/mm/mprotect.c
> > +++ b/mm/mprotect.c
> > @@ -106,6 +106,12 @@ static unsigned long change_pte_range(st
> > 					continue;
> > 
> > 				/*
> > +				 * Can't migrate pinned pages, avoid touching them.
> > +				 */
> > +				if (page_maybe_dma_pinned(page))
> > +					continue;
> > +
> > +				/*
> > 
> 
> I have a similar problem with userfaultfd changing protection for
> DMA-pinned pages. For userfaultfd it is important to know how many
> pages were actually modified.
> 
> I am working on a vectored UFFDIO_WRITEPROTECTV that aborts once
> a pinned page is encountered, but also returns the number of pages
> that were properly protected. I still need to do some work to
> send patches for that as it requires further changes (to return
> the number of pages that were handled).
> 
> But for the matter of your patch, is it possible to make this
> test generic (not migration specific) and rely on a new flag in
> cp_flags? I can of course make this change later if you prefer it
> this way.

I have no objection to making it apply more widely, but I'm currently
only interested in the rmap users. If userspace does mprotect() on it's
own pages, it gets to keep whatever pieces are the result of that.