All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Mack <daniel@zonque.org>
To: mturquette@baylibre.com, sboyd@kernel.org
Cc: linux-clk@vger.kernel.org, robh+dt@kernel.org,
	devicetree@vger.kernel.org, kuninori.morimoto.gx@renesas.com,
	Daniel Mack <daniel@zonque.org>
Subject: [PATCH RESEND v4 8/9] clk: cs2000-cp: freeze config during register fiddling
Date: Tue, 25 Jan 2022 10:33:35 +0100	[thread overview]
Message-ID: <20220125093336.226787-9-daniel@zonque.org> (raw)
In-Reply-To: <20220125093336.226787-1-daniel@zonque.org>

Make sure to freeze the configuration of the chip during the programming
of 32-bit registers. This avoids the processing of invalid intermediate
states.

Signed-off-by: Daniel Mack <daniel@zonque.org>
---
 drivers/clk/clk-cs2000-cp.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/clk/clk-cs2000-cp.c b/drivers/clk/clk-cs2000-cp.c
index 9f99e39b41f2..1baf0595ba59 100644
--- a/drivers/clk/clk-cs2000-cp.c
+++ b/drivers/clk/clk-cs2000-cp.c
@@ -52,6 +52,7 @@
 #define FRACNSRC_DYNAMIC	(1 << 0)
 
 /* GLOBAL_CFG */
+#define FREEZE		(1 << 7)
 #define ENDEV2		(0x1)
 
 /* FUNC_CFG1 */
@@ -335,6 +336,10 @@ static int __cs2000_set_rate(struct cs2000_priv *priv, int ch,
 {
 	int ret;
 
+	ret = cs2000_bset(priv, GLOBAL_CFG, FREEZE, FREEZE);
+	if (ret < 0)
+		return ret;
+
 	ret = cs2000_select_ratio_mode(priv, rate, parent_rate);
 	if (ret < 0)
 		return ret;
@@ -347,6 +352,10 @@ static int __cs2000_set_rate(struct cs2000_priv *priv, int ch,
 	if (ret < 0)
 		return ret;
 
+	ret = cs2000_bset(priv, GLOBAL_CFG, FREEZE, 0);
+	if (ret < 0)
+		return ret;
+
 	priv->saved_rate	= rate;
 	priv->saved_parent_rate	= parent_rate;
 
-- 
2.31.1


  parent reply	other threads:[~2022-01-25  9:46 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-25  9:33 [PATCH RESEND v4 0/9] clk: cs2000-cp: add dynamic mode and more features Daniel Mack
2022-01-25  9:33 ` [PATCH RESEND v4 1/9] dt-bindings: clock: convert cs2000-cp bindings to yaml Daniel Mack
2022-01-25 22:29   ` Stephen Boyd
2022-02-08 13:46     ` Daniel Mack
2022-01-25  9:33 ` [PATCH RESEND v4 2/9] dt-bindings: clock: cs2000-cp: document aux-output-source Daniel Mack
2022-01-25 22:29   ` Stephen Boyd
2022-01-25  9:33 ` [PATCH RESEND v4 3/9] dt-bindings: clock: cs2000-cp: document cirrus,clock-skip flag Daniel Mack
2022-01-25 22:29   ` Stephen Boyd
2022-01-25  9:33 ` [PATCH RESEND v4 4/9] dt-bindings: clock: cs2000-cp: document cirrus,dynamic-mode Daniel Mack
2022-01-25 22:29   ` Stephen Boyd
2022-01-25  9:33 ` [PATCH RESEND v4 5/9] clk: cs2000-cp: Make aux output function controllable Daniel Mack
2022-01-25 22:29   ` Stephen Boyd
2022-01-25  9:33 ` [PATCH RESEND v4 6/9] clk: cs2000-cp: add support for dynamic mode Daniel Mack
2022-01-25 22:30   ` Stephen Boyd
2022-01-25  9:33 ` [PATCH RESEND v4 7/9] clk: cs2000-cp: make clock skip setting configurable Daniel Mack
2022-01-25 22:30   ` Stephen Boyd
2022-01-25  9:33 ` Daniel Mack [this message]
2022-01-25 22:30   ` [PATCH RESEND v4 8/9] clk: cs2000-cp: freeze config during register fiddling Stephen Boyd
2022-01-25  9:33 ` [PATCH RESEND v4 9/9] clk: cs2000-cp: convert driver to regmap Daniel Mack
2022-01-25 22:30   ` Stephen Boyd
  -- strict thread matches above, loose matches on Subject: below --
2021-12-14 12:09 [PATCH RESEND v4 0/9] clk: cs2000-cp: add dynamic mode and more features Daniel Mack
2021-12-14 12:09 ` [PATCH RESEND v4 8/9] clk: cs2000-cp: freeze config during register fiddling Daniel Mack
2021-10-15 14:53 [PATCH RESEND v4 0/9] clk: cs2000-cp: add dynamic mode and more features Daniel Mack
2021-10-15 14:53 ` [PATCH RESEND v4 8/9] clk: cs2000-cp: freeze config during register fiddling Daniel Mack

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220125093336.226787-9-daniel@zonque.org \
    --to=daniel@zonque.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.