From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To: bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net
Cc: netdev@vger.kernel.org, magnus.karlsson@intel.com,
alexandr.lobakin@intel.com,
Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Subject: [PATCH bpf-next v5 1/8] ice: remove likely for napi_complete_done
Date: Tue, 25 Jan 2022 17:04:39 +0100 [thread overview]
Message-ID: <20220125160446.78976-2-maciej.fijalkowski@intel.com> (raw)
In-Reply-To: <20220125160446.78976-1-maciej.fijalkowski@intel.com>
Remove the likely before napi_complete_done as this is the unlikely case
when busy-poll is used. Removing this has a positive performance impact
for busy-poll and no negative impact to the regular case.
Reviewed-by: Alexander Lobakin <alexandr.lobakin@intel.com>
Acked-by: Magnus Karlsson <magnus.karlsson@intel.com>
Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
---
drivers/net/ethernet/intel/ice/ice_txrx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_txrx.c b/drivers/net/ethernet/intel/ice/ice_txrx.c
index 3e38695f1c9d..e661d0e45b9b 100644
--- a/drivers/net/ethernet/intel/ice/ice_txrx.c
+++ b/drivers/net/ethernet/intel/ice/ice_txrx.c
@@ -1513,7 +1513,7 @@ int ice_napi_poll(struct napi_struct *napi, int budget)
/* Exit the polling mode, but don't re-enable interrupts if stack might
* poll us due to busy-polling
*/
- if (likely(napi_complete_done(napi, work_done))) {
+ if (napi_complete_done(napi, work_done)) {
ice_net_dim(q_vector);
ice_enable_interrupt(q_vector);
} else {
--
2.33.1
next prev parent reply other threads:[~2022-01-25 16:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 16:04 [PATCH v5 bpf-next 0/8] xsk: Intel driver improvements Maciej Fijalkowski
2022-01-25 16:04 ` Maciej Fijalkowski [this message]
2022-01-25 16:04 ` [PATCH bpf-next v5 2/8] ice: xsk: force rings to be sized to power of 2 Maciej Fijalkowski
2022-01-25 16:04 ` [PATCH bpf-next v5 3/8] ice: xsk: handle SW XDP ring wrap and bump tail more often Maciej Fijalkowski
2022-01-25 16:04 ` [PATCH bpf-next v5 4/8] ice: make Tx threshold dependent on ring length Maciej Fijalkowski
2022-01-25 16:04 ` [PATCH bpf-next v5 5/8] i40e: xsk: move tmp desc array from driver to pool Maciej Fijalkowski
2022-01-25 16:04 ` [PATCH bpf-next v5 6/8] ice: xsk: avoid potential dead AF_XDP Tx processing Maciej Fijalkowski
2022-01-25 16:04 ` [PATCH bpf-next v5 7/8] ice: xsk: improve AF_XDP ZC Tx and use batching API Maciej Fijalkowski
2022-01-25 16:04 ` [PATCH bpf-next v5 8/8] ice: xsk: borrow xdp_tx_active logic from i40e Maciej Fijalkowski
2022-01-26 8:07 ` Magnus Karlsson
2022-01-27 16:40 ` [PATCH v5 bpf-next 0/8] xsk: Intel driver improvements patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220125160446.78976-2-maciej.fijalkowski@intel.com \
--to=maciej.fijalkowski@intel.com \
--cc=alexandr.lobakin@intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.