Re: [PATCH] ASoC: cs47l15: Ensure regmap_irq is built

From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org,
	Lucas Tanure <tanureal@opensource.cirrus.com>,
	patches@opensource.cirrus.com,
	Liam Girdwood <lgirdwood@gmail.com>,
	David Rhodes <david.rhodes@cirrus.com>,
	James Schulman <james.schulman@cirrus.com>
Subject: Re: [PATCH] ASoC: cs47l15: Ensure regmap_irq is built
Date: Thu, 3 Feb 2022 10:05:22 +0000	[thread overview]
Message-ID: <20220203100522.GE18506@ediswmail.ad.cirrus.com> (raw)
In-Reply-To: <20220202191700.3654382-1-broonie@kernel.org>

On Wed, Feb 02, 2022 at 07:17:00PM +0000, Mark Brown wrote:
> The cs47l15 driver uses regmap_irq but does not ensure that it is built,
> causing build failures if nothing else being build requires the helpers.
> Add the appropriate select.
> 
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
>  sound/soc/codecs/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
> index 2fd21004688c..69fd11b2b046 100644
> --- a/sound/soc/codecs/Kconfig
> +++ b/sound/soc/codecs/Kconfig
> @@ -733,6 +733,7 @@ config SND_SOC_CS4349
>  
>  config SND_SOC_CS47L15
>  	tristate
> +	select REGMAP_IRQ
>  

Would it be better to have depends on MFD_CS47L15 instead,
that way the other dependencies would be covered as well? I think
these were added before implies was a thing, and thus
dependencies didn't matter, since they could only be selected
which ignored deps anyway.

I would expect L35, L85, L90, L92 to be affected as well. Happy
to do a patch to fix this up, if you prefer?

Thanks,
Charles