Re: [PATCH 07/20] bus: mhi: ep: Add support for creating and destroying MHI EP devices

From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Alex Elder <elder@ieee.org>
Cc: mhi@lists.linux.dev, hemantk@codeaurora.org,
	bbhatt@codeaurora.org, quic_jhugo@quicinc.com,
	vinod.koul@linaro.org, bjorn.andersson@linaro.org,
	dmitry.baryshkov@linaro.org, skananth@codeaurora.org,
	vpernami@codeaurora.org, vbadigan@codeaurora.org,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 07/20] bus: mhi: ep: Add support for creating and destroying MHI EP devices
Date: Thu, 3 Feb 2022 20:43:31 +0530	[thread overview]
Message-ID: <20220203151331.GF6298@thinkpad> (raw)
In-Reply-To: <08a3b725-d211-b363-a3b4-2a325367b976@ieee.org>

On Wed, Jan 05, 2022 at 06:28:08PM -0600, Alex Elder wrote:
> On 12/2/21 5:35 AM, Manivannan Sadhasivam wrote:
> > This commit adds support for creating and destroying MHI endpoint devices.
> > The MHI endpoint devices binds to the MHI endpoint channels and are used
> > to transfer data between MHI host and endpoint device.
> > 
> > There is a single MHI EP device for each channel pair. The devices will be
> > created when the corresponding channels has been started by the host and
> > will be destroyed during MHI EP power down and reset.
> > 
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > ---
> >   drivers/bus/mhi/ep/main.c | 85 +++++++++++++++++++++++++++++++++++++++
> >   1 file changed, 85 insertions(+)
> > 
> > diff --git a/drivers/bus/mhi/ep/main.c b/drivers/bus/mhi/ep/main.c
> > index ce0f99f22058..f0b5f49db95a 100644
> > --- a/drivers/bus/mhi/ep/main.c
> > +++ b/drivers/bus/mhi/ep/main.c
> > @@ -63,6 +63,91 @@ static struct mhi_ep_device *mhi_ep_alloc_device(struct mhi_ep_cntrl *mhi_cntrl)
> >   	return mhi_dev;
> >   }
> > +static int mhi_ep_create_device(struct mhi_ep_cntrl *mhi_cntrl, u32 ch_id)
> > +{
> > +	struct mhi_ep_device *mhi_dev;
> > +	struct mhi_ep_chan *mhi_chan = &mhi_cntrl->mhi_chan[ch_id];
> > +	int ret;
> > +
> > +	mhi_dev = mhi_ep_alloc_device(mhi_cntrl);
> > +	if (IS_ERR(mhi_dev))
> > +		return PTR_ERR(mhi_dev);
> > +
> > +	mhi_dev->dev_type = MHI_DEVICE_XFER;
> 
> Elsewhere (at least in mhi_ep_process_tre_ring()) in your code
> you assume that the even-numbered channel is UL.
> 
> I would say, either use that assumption throughout, or do
> not use that assumption at all.  (I prefer the latter.)
> 
> I don't really like how this assumes that the channels
> are defined in adjacent pairs.  It assumes one is
> upload and the next one is download, but doesn't
> specify the order in which they're defined.  If
> you're going to assume they are defined in pairs, you
> should be able to assume which one is defined first,
> and then simplify this code (and even verify that
> they are defined UL before DL, perhaps).
> 

Yes, the UL channel is always even numbered and DL is odd.
I've removed the checks.

> > +	/* Configure primary channel */
> > +	if (mhi_chan->dir == DMA_TO_DEVICE) {
> > +		mhi_dev->ul_chan = mhi_chan;
> > +		mhi_dev->ul_chan_id = mhi_chan->chan;
> > +	} else {
> > +		mhi_dev->dl_chan = mhi_chan;
> > +		mhi_dev->dl_chan_id = mhi_chan->chan;
> > +	}
> > +
> > +	get_device(&mhi_dev->dev);
> > +	mhi_chan->mhi_dev = mhi_dev;
> > +
> > +	/* Configure secondary channel as well */
> > +	mhi_chan++;
> > +	if (mhi_chan->dir == DMA_TO_DEVICE) {
> > +		mhi_dev->ul_chan = mhi_chan;
> > +		mhi_dev->ul_chan_id = mhi_chan->chan;
> > +	} else {
> > +		mhi_dev->dl_chan = mhi_chan;
> > +		mhi_dev->dl_chan_id = mhi_chan->chan;
> > +	}
> > +
> > +	get_device(&mhi_dev->dev);
> > +	mhi_chan->mhi_dev = mhi_dev;
> > +
> > +	/* Channel name is same for both UL and DL */
> 
> You could verify the two channels indeed have the
> same name.
> 

done.

Thanks,
Mani