From: Vladimir Oltean <olteanv@gmail.com>
To: Mans Rullgard <mans@mansr.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Juergen Borleis <kernel@pengutronix.de>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net: dsa: lan9303: add VLAN IDs to master device
Date: Sun, 20 Feb 2022 19:00:37 +0200 [thread overview]
Message-ID: <20220220170037.w6r6vaduop4mbryh@skbuf> (raw)
In-Reply-To: <20220216235930.q2l3lr7p7pf5hozo@skbuf>
On Thu, Feb 17, 2022 at 01:59:30AM +0200, Vladimir Oltean wrote:
> On Wed, Feb 16, 2022 at 08:48:18PM +0000, Mans Rullgard wrote:
> > If the master device does VLAN filtering, the IDs used by the switch
> > must be added for any frames to be received. Do this in the
> > port_enable() function, and remove them in port_disable().
> >
> > Signed-off-by: Mans Rullgard <mans@mansr.com>
> > ---
>
> Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
There's a problem with this patch.
CONFIG_NET_DSA_SMSC_LAN9303 is not user-selectable, but it is selected
by CONFIG_NET_DSA_SMSC_LAN9303_I2C or CONFIG_NET_DSA_SMSC_LAN9303_MDIO.
The point is that config options that aren't user-selectable but are
automatically selected shouldn't have dependencies. AFAIK, the
dependencies should be transferred to the user-facing options
(_I2C and _MDIO).
What happens is that if you make CONFIG_VLAN_8021Q a module, you get
this warning:
WARNING: unmet direct dependencies detected for NET_DSA_SMSC_LAN9303
Depends on [m]: NETDEVICES [=y] && NET_DSA [=y] && (VLAN_8021Q [=m] || VLAN_8021Q [=m]=n)
Selected by [y]:
- NET_DSA_SMSC_LAN9303_I2C [=y] && NETDEVICES [=y] && NET_DSA [=y] && I2C [=y]
- NET_DSA_SMSC_LAN9303_MDIO [=y] && NETDEVICES [=y] && NET_DSA [=y]
The point of the dependency was to force the LAN9303 driver as a module
if 8021Q is a module, but this doesn't happen because the dependency
isn't where it should be.
next prev parent reply other threads:[~2022-02-20 17:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 20:48 [PATCH v2] net: dsa: lan9303: add VLAN IDs to master device Mans Rullgard
2022-02-16 21:44 ` Florian Fainelli
2022-02-16 23:59 ` Vladimir Oltean
2022-02-20 17:00 ` Vladimir Oltean [this message]
2022-02-17 18:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220220170037.w6r6vaduop4mbryh@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mans@mansr.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.