From: kernel test robot <lkp@intel.com>
To: Markuss Broks <markuss.broks@gmail.com>, linux-kernel@vger.kernel.org
Cc: kbuild-all@lists.01.org, phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
Markuss Broks <markuss.broks@gmail.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Henrik Rydberg <rydberg@bitmath.org>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v6 2/2] Input: add Imagis touchscreen driver
Date: Wed, 23 Feb 2022 23:41:41 +0800 [thread overview]
Message-ID: <202202232342.Ew209GPR-lkp@intel.com> (raw)
In-Reply-To: <20220222203414.8656-3-markuss.broks@gmail.com>
Hi Markuss,
I love your patch! Perhaps something to improve:
[auto build test WARNING on dtor-input/next]
[also build test WARNING on linux/master robh/for-next linus/master v5.17-rc5 next-20220222]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Markuss-Broks/Add-support-for-Imagis-touchscreens/20220223-043645
base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
config: arm-randconfig-s031-20220223 (https://download.01.org/0day-ci/archive/20220223/202202232342.Ew209GPR-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.4-dirty
# https://github.com/0day-ci/linux/commit/bc77ee5e0d7309edca7d65925c6afa05334b0b01
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Markuss-Broks/Add-support-for-Imagis-touchscreens/20220223-043645
git checkout bc77ee5e0d7309edca7d65925c6afa05334b0b01
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=arm SHELL=/bin/bash drivers/input/touchscreen/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/input/touchscreen/imagis.c:65:35: sparse: sparse: cast to restricted __be32
vim +65 drivers/input/touchscreen/imagis.c
40
41 static int imagis_i2c_read_reg(struct imagis_ts *ts,
42 unsigned int reg, unsigned int *buffer)
43 {
44 __be32 reg_be = cpu_to_be32(reg);
45 struct i2c_msg msg[] = {
46 {
47 .addr = ts->client->addr,
48 .flags = 0,
49 .buf = (unsigned char *)®_be,
50 .len = sizeof(reg_be),
51 }, {
52 .addr = ts->client->addr,
53 .flags = I2C_M_RD,
54 .buf = (unsigned char *)buffer,
55 .len = sizeof(reg_be),
56 },
57 };
58 int ret, error;
59 int retry = IST3038C_I2C_RETRY_COUNT;
60
61 /* Retry in case the controller fails to respond */
62 do {
63 ret = i2c_transfer(ts->client->adapter, msg, ARRAY_SIZE(msg));
64 if (ret == ARRAY_SIZE(msg)) {
> 65 *buffer = be32_to_cpu(*buffer);
66 return 0;
67 }
68
69 error = ret < 0 ? ret : -EIO;
70 dev_err(&ts->client->dev,
71 "%s - i2c_transfer failed: %d (%d)\n",
72 __func__, error, ret);
73 } while (--retry);
74
75 return error;
76 }
77
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
next prev parent reply other threads:[~2022-02-23 15:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 20:34 [PATCH v6 0/2] Add support for Imagis touchscreens Markuss Broks
2022-02-22 20:34 ` [PATCH v6 1/2] dt-bindings: input/touchscreen: bindings for Imagis Markuss Broks
2022-02-23 8:07 ` Krzysztof Kozlowski
2022-02-23 15:57 ` Rob Herring
2022-02-22 20:34 ` [PATCH v6 2/2] Input: add Imagis touchscreen driver Markuss Broks
2022-02-23 4:59 ` kernel test robot
2022-02-23 15:41 ` kernel test robot [this message]
2022-02-24 19:09 kernel test robot
2022-02-25 7:55 ` Dan Carpenter
2022-02-25 7:55 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202202232342.Ew209GPR-lkp@intel.com \
--to=lkp@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=kbuild-all@lists.01.org \
--cc=krzk@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markuss.broks@gmail.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=rydberg@bitmath.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.