Re: [PATCH v4 2/2] parse-options.c: add style checks for usage-strings

From: Abhradeep Chakraborty <chakrabortyabhradeep79@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: "Abhradeep Chakraborty" <chakrabortyabhradeep79@gmail.com>,
	"Eric Sunshine" <sunshine@sunshineco.com>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Junio C Hamano" <gitster@pobox.com>,
	"Julia Lawall" <julia.lawall@inria.fr>, git <git@vger.kernel.org>
Subject: Re: [PATCH v4 2/2] parse-options.c: add style checks for usage-strings
Date: Fri, 25 Feb 2022 21:31:47 +0530	[thread overview]
Message-ID: <20220225160147.14824-1-chakrabortyabhradeep79@gmail.com> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.2202251632320.11118@tvgsbejvaqbjf.bet>

Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

> As I just pointed out in
> https://lore.kernel.org/git/nycvar.QRO.7.76.6.2202251600210.11118@tvgsbejv=
> aqbjf.bet/,
> it seems that replacing the static check presented in v1 by a runtime
> check needs to be reverted.
>
> In addition to the example I presented, there is another compelling reason
> to do so: with the static check, we can detect incorrect usage strings in
> all code, even in code that is platform-dependent (such as in
> `fsmonitor--daemon`).

First of all, thank you so much for putting so much time to look into
my PR. I appriciate your research about various possible outcomes of this
Patch request.

I saw your mail where you listed some of the disadvantages of the current
version. I also agree with the arguments you provided and it is also true
that one wouldn't find any clue by seeing the output of the `CI` link
you mentioned (i.e. https://github.com/git/git/runs/5312914410?check_suite_focus=true).

Let's see what Junio, Ævar and others say about this.

Thanks :)