From: Marc Kleine-Budde <mkl@pengutronix.de>
To: trix@redhat.com
Cc: mani@kernel.org, thomas.kopp@microchip.com, wg@grandegger.com,
davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
nathan@kernel.org, ndesaulniers@google.com,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] can: mcp251xfd: return errors from mcp251xfd_register_get_dev_id
Date: Sat, 19 Mar 2022 16:53:30 +0100 [thread overview]
Message-ID: <20220319155330.d62uvu47pujhjocy@pengutronix.de> (raw)
In-Reply-To: <20220319153128.2164120-1-trix@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1030 bytes --]
On 19.03.2022 08:31:28, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> Clang static analysis reports this issue
> mcp251xfd-core.c:1813:7: warning: The left operand
> of '&' is a garbage value
> FIELD_GET(MCP251XFD_REG_DEVID_ID_MASK, dev_id),
> ^ ~~~~~~
>
> dev_id is set in a successful call to
> mcp251xfd_register_get_dev_id(). Though the status
> of calls made by mcp251xfd_register_get_dev_id()
> are checked and handled, their status' are not
> returned. So return err.
>
> Fixes: 55e5b97f003e ("can: mcp25xxfd: add driver for Microchip MCP25xxFD SPI CAN")
> Signed-off-by: Tom Rix <trix@redhat.com>
Thanks for your patch, applied to linux-can/testing.
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2022-03-19 15:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-19 15:31 [PATCH] can: mcp251xfd: return errors from mcp251xfd_register_get_dev_id trix
2022-03-19 15:53 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220319155330.d62uvu47pujhjocy@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mani@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thomas.kopp@microchip.com \
--cc=trix@redhat.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.