From: Peter Zijlstra <peterz@infradead.org>
To: Steve Capper <steve.capper@arm.com>
Cc: linux-mm@kvack.org, David Hildenbrand <david@redhat.com>,
Anshuman Khandual <anshuman.khandual@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>
Subject: Re: [PATCH] tlb: hugetlb: Add arm64 contiguous hint awareness
Date: Thu, 24 Mar 2022 15:33:31 +0100 [thread overview]
Message-ID: <20220324143331.GF8939@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <20220323165218.35499-1-steve.capper@arm.com>
On Wed, Mar 23, 2022 at 04:52:18PM +0000, Steve Capper wrote:
> +#define tlb_remove_huge_tlb_entry(h, tlb, ptep, address) \
> + do { \
> + unsigned long _sz = huge_page_size(h); \
> + if (_sz == CONT_PTE_SIZE) \
> + tlb_flush_pte_range(tlb, address, _sz); \
> + else if (_sz == PMD_SIZE) \
> + tlb_flush_pmd_range(tlb, address, _sz); \
> + else if (_sz == CONT_PMD_SIZE) \
> + tlb_flush_pmd_range(tlb, address, _sz); \
> + else if (_sz == PUD_SIZE) \
> + tlb_flush_pud_range(tlb, address, _sz); \
> + __tlb_remove_tlb_entry(tlb, ptep, address); \
> + } while (0)
It occurs to me that perhaps this can be written like:
unsigned long _sz = huge_page_size(h);
if (_sz >= P4D_SIZE)
tlb_flush_p4d_range(tlb, address, _sz);
else if (_sz >= PUD_SIZE)
tlb_flush_pud_range(tlb, address, _sz);
else if (_sz >= PMD_SIZE)
tlb_flush_pmd_range(tlb, address, _sz);
else
tlb_flush_pte_range(tlb, address, _sz);
__tlb_remove_tlb_entry(tlb, ptep, address);
And then it can still be generic..
next prev parent reply other threads:[~2022-03-24 14:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-23 16:52 [PATCH] tlb: hugetlb: Add arm64 contiguous hint awareness Steve Capper
2022-03-23 18:30 ` Catalin Marinas
2022-03-24 14:33 ` Peter Zijlstra [this message]
2022-03-24 14:35 ` Steve Capper
2022-03-24 15:58 ` Peter Zijlstra
2022-03-24 16:11 ` Steve Capper
2022-03-30 11:25 ` [PATCH v2] tlb: hugetlb: Add more sizes to tlb_remove_huge_tlb_entry Steve Capper
2022-03-30 12:05 ` David Hildenbrand
2022-03-30 14:04 ` Anshuman Khandual
2022-04-06 11:21 ` Peter Zijlstra
2022-04-04 6:07 ` Anshuman Khandual
2022-04-05 14:26 ` Catalin Marinas
2022-04-06 11:40 ` Peter Zijlstra
2022-04-06 12:05 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220324143331.GF8939@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=anshuman.khandual@arm.com \
--cc=catalin.marinas@arm.com \
--cc=david@redhat.com \
--cc=linux-mm@kvack.org \
--cc=steve.capper@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.