From: Paul Lemmermann <thepaulodoom@thepaulodoom.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: davem@davemloft.net, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: aes_generic: fixed styling warnings
Date: Mon, 28 Mar 2022 07:51:37 -0500 [thread overview]
Message-ID: <20220328125137.bsbvroyxcjw6rl5m@hp-amd-paul> (raw)
In-Reply-To: <CAMj1kXHCR1nD24WDnYpD4Nu23x9+hw+=7EXOpq7y7m9LDk2J0w@mail.gmail.com>
On Mon, Mar 28, 2022 at 09:39:14AM +0200, Ard Biesheuvel wrote:
> (please keep the cc's)
>
> On Mon, 28 Mar 2022 at 00:46, Paul Lemmermann
> <thepaulodoom@thepaulodoom.com> wrote:
> >
> > On Sun, Mar 27, 2022 at 01:41:19PM +0200, Ard Biesheuvel wrote:
> > > On Sat, 26 Mar 2022 at 18:48, Paul Lemmermann
> > > <thepaulodoom@thepaulodoom.com> wrote:
> > > >
> > > > Fixed all styling warnings from the checkpatch.pl script.
> > > >
> > > > Signed-off-by: Paul Lemmermann <thepaulodoom@thepaulodoom.com>
> > >
> > > Did you test this code after 'fixing' it?
> > >
> > No, I did not. Now that I scrutinized it a bit more, I realized the
> > kernel coding conventions. Sorry about that, this is my first patch.
>
> In that case, welcome!
>
> This is not about coding conventions. This is about correctness.
>
> For instance,
>
> > > >
> > > > -#define f_nround(bo, bi, k) do {\
> > > > +#define f_nround(bo, bi, k) while (0) {\
> > > > f_rn(bo, bi, 0, k); \
> > > > f_rn(bo, bi, 1, k); \
> > > > f_rn(bo, bi, 2, k); \
> > > > f_rn(bo, bi, 3, k); \
> > > > k += 4; \
> > > > -} while (0)
> > > > +}
> > > >
>
> Why are you making this change, and why do you think it produces the
> same result?
>
> > Can you remove everything in the patch past the section with line
> > 1144, or do I have to resubit the patch?
> >
>
> checkpatch.pl is a useful tool for finding style issues, but please
> use it with care. And changing decades old code just to fix issues
> reported by checkpatch.pl is really just pointless churn.
>
> So let's just drop this patch altogether, shall we? If you're
> interested in helping out, please have a look at the staging/ tree -
> there is a lot of code there that needs cleaning up.
>
Yes, we can drop the patch. Thank you so much for your help and support.
Looking forward to contributing more to the Linux kernel.
Thanks,
Paul
next prev parent reply other threads:[~2022-03-28 12:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-26 17:20 [PATCH] crypto: aes_generic: fixed styling warnings Paul Lemmermann
2022-03-27 11:41 ` Ard Biesheuvel
[not found] ` <20220327224009.2jotnczk67j4cfh2@hp-amd-paul>
2022-03-28 7:39 ` Ard Biesheuvel
2022-03-28 12:51 ` Paul Lemmermann [this message]
2022-04-11 10:34 ` [crypto] 8505b026c9: hwsim.fils_sk_hlp_oom.fail kernel test robot
2022-04-11 10:34 ` kernel test robot
2022-04-12 20:36 ` Paul Lemmermann
2022-04-12 20:36 ` Paul Lemmermann
2022-03-27 15:13 [PATCH] crypto: aes_generic: fixed styling warnings kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220328125137.bsbvroyxcjw6rl5m@hp-amd-paul \
--to=thepaulodoom@thepaulodoom.com \
--cc=ardb@kernel.org \
--cc=davem@davemloft.net \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.