From: Christoph Hellwig <hch@lst.de>
To: Jiri Slaby <jslaby@suse.cz>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Jan Kara <jack@suse.cz>
Subject: Re: [PATCH] block: restore the old set_task_ioprio() behaviour wrt PF_EXITING
Date: Tue, 29 Mar 2022 08:55:35 +0200 [thread overview]
Message-ID: <20220329065535.GA20158@lst.de> (raw)
In-Reply-To: <20220328085928.7899-1-jslaby@suse.cz>
> task_lock(task);
> if (task->flags & PF_EXITING) {
> - err = -ESRCH;
> kmem_cache_free(iocontext_cachep, ioc);
> goto out;
Please add a commnt here why we are not returning an error, otherwise
this is just getting "fixed" over and over again.
prev parent reply other threads:[~2022-03-29 6:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 8:59 [PATCH] block: restore the old set_task_ioprio() behaviour wrt PF_EXITING Jiri Slaby
2022-03-28 9:59 ` Jan Kara
2022-03-28 12:36 ` Jens Axboe
2022-03-29 6:55 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220329065535.GA20158@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=jack@suse.cz \
--cc=jslaby@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.