Re: [PATCH 26/39] ALSA: intel_hdmi: Fix the missing snd_card_free() call at probe error

From: kernel test robot <lkp@intel.com>
To: Takashi Iwai <tiwai@suse.de>, alsa-devel@alsa-project.org
Cc: kbuild-all@lists.01.org
Subject: Re: [PATCH 26/39] ALSA: intel_hdmi: Fix the missing snd_card_free() call at probe error
Date: Wed, 13 Apr 2022 01:14:09 +0800	[thread overview]
Message-ID: <202204130129.SNA1B1hM-lkp@intel.com> (raw)
In-Reply-To: <20220412102636.16000-27-tiwai@suse.de>

Hi Takashi,

I love your patch! Yet something to improve:

[auto build test ERROR on tiwai-sound/for-next]
[also build test ERROR on v5.18-rc2 next-20220412]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Takashi-Iwai/ALSA-Fix-error-handling-order-at-probe-error/20220412-183941
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next
config: i386-randconfig-a016-20220411 (https://download.01.org/0day-ci/archive/20220413/202204130129.SNA1B1hM-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.2.0-19) 11.2.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/9e76730fee819f96c44f07e9a100c907457aed8b
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Takashi-Iwai/ALSA-Fix-error-handling-order-at-probe-error/20220412-183941
        git checkout 9e76730fee819f96c44f07e9a100c907457aed8b
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   sound/x86/intel_hdmi_audio.c: In function 'hdmi_lpe_audio_probe':
>> sound/x86/intel_hdmi_audio.c:1820:16: error: implicit declaration of function 'snd_card_free_on_error'; did you mean 'snd_ctl_free_one'? [-Werror=implicit-function-declaration]
    1820 |         return snd_card_free_on_error(&pdev->dev, __hdmi_lpe_audio_probe(pdev));
         |                ^~~~~~~~~~~~~~~~~~~~~~
         |                snd_ctl_free_one
   cc1: some warnings being treated as errors

vim +1820 sound/x86/intel_hdmi_audio.c

  1817	
  1818	static int hdmi_lpe_audio_probe(struct platform_device *pdev)
  1819	{
> 1820		return snd_card_free_on_error(&pdev->dev, __hdmi_lpe_audio_probe(pdev));
  1821	}
  1822	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp