From: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Stuart Yoder <stuyoder@gmail.com>,
Laurentiu Tudor <laurentiu.tudor@nxp.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Jason Gunthorpe <jgg@ziepe.ca>,
Damien Le Moal <damien.lemoal@opensource.wdc.com>
Subject: Re: [PATCH v2] bus: fsl-mc-msi: fix MSI descriptor mutex lock for msi_first_desc()
Date: Wed, 27 Apr 2022 10:38:46 +0000 [thread overview]
Message-ID: <20220427103846.hjnkfn5fpuqlzuap@shindev> (raw)
In-Reply-To: <20220412075636.755454-1-shinichiro.kawasaki@wdc.com>
On Apr 12, 2022 / 16:56, Shin'ichiro Kawasaki wrote:
> Commit e8604b1447b4 ("bus: fsl-mc-msi: Simplify MSI descriptor
> handling") introduced a call to the helper function msi_first_desc(),
> which needs MSI descriptor mutex lock before call. However, the required
> mutex lock was not added. This resulted in lockdep assert WARNING [1].
> Fix this by adding the mutex lock and unlock around the function call.
This is a gentle reminder. Comments or merge to upstream will be appreciated.
--
Best Regards,
Shin'ichiro Kawasaki
next prev parent reply other threads:[~2022-04-27 10:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 7:56 [PATCH v2] bus: fsl-mc-msi: fix MSI descriptor mutex lock for msi_first_desc() Shin'ichiro Kawasaki
2022-04-27 10:38 ` Shinichiro Kawasaki [this message]
2022-04-27 17:38 ` Thomas Gleixner
2022-04-27 17:46 ` [tip: irq/urgent] bus: fsl-mc-msi: Fix " tip-bot2 for Shin'ichiro Kawasaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220427103846.hjnkfn5fpuqlzuap@shindev \
--to=shinichiro.kawasaki@wdc.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=jgg@ziepe.ca \
--cc=laurentiu.tudor@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stuyoder@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.