From: Eugene Syromiatnikov <esyr@redhat.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: nvdimm@lists.linux.dev, robert.hu@linux.intel.com,
vishal.l.verma@intel.com, hch@lst.de, linux-acpi@vger.kernel.org,
ldv@strace.io
Subject: Re: [PATCH 6/6] nvdimm/region: Delete nd_blk_region infrastructure
Date: Tue, 3 May 2022 05:43:06 +0200 [thread overview]
Message-ID: <20220503034306.GA30980@asgard.redhat.com> (raw)
In-Reply-To: <164688418803.2879318.1302315202397235855.stgit@dwillia2-desk3.amr.corp.intel.com>
On Wed, Mar 09, 2022 at 07:49:48PM -0800, Dan Williams wrote:
> Now that the nd_namespace_blk infrastructure is removed, delete all the
> region machinery to coordinate provisioning aliased capacity between
> PMEM and BLK.
> --- a/include/uapi/linux/ndctl.h
> +++ b/include/uapi/linux/ndctl.h
> @@ -189,7 +189,6 @@ static inline const char *nvdimm_cmd_name(unsigned cmd)
> #define ND_DEVICE_REGION_BLK 3 /* nd_region: (parent of BLK namespaces) */
> #define ND_DEVICE_NAMESPACE_IO 4 /* legacy persistent memory */
> #define ND_DEVICE_NAMESPACE_PMEM 5 /* PMEM namespace (may alias with BLK) */
> -#define ND_DEVICE_NAMESPACE_BLK 6 /* BLK namespace (may alias with PMEM) */
As [1] suggests, this would break compilation of at least one Debian
package, as well as unknown number of any other potential users of this part
of UAPI.
> #define ND_DEVICE_DAX_PMEM 7 /* Device DAX interface to pmem */
>
> enum nd_driver_flags {
> @@ -198,7 +197,6 @@ enum nd_driver_flags {
> ND_DRIVER_REGION_BLK = 1 << ND_DEVICE_REGION_BLK,
> ND_DRIVER_NAMESPACE_IO = 1 << ND_DEVICE_NAMESPACE_IO,
> ND_DRIVER_NAMESPACE_PMEM = 1 << ND_DEVICE_NAMESPACE_PMEM,
> - ND_DRIVER_NAMESPACE_BLK = 1 << ND_DEVICE_NAMESPACE_BLK,
The same probably applies here.
[1] https://sources.debian.org/src/ipmctl/03.00.00.0429-1/src/os/linux/lnx_system.c/?hl=334#L334
prev parent reply other threads:[~2022-05-03 3:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 3:49 [PATCH 0/6] libnvdimm: Jettison block-aperture-window support Dan Williams
2022-03-10 3:49 ` [PATCH 1/6] nvdimm/region: Fix default alignment for small regions Dan Williams
2022-03-10 7:09 ` Christoph Hellwig
2022-03-10 3:49 ` [PATCH 2/6] nvdimm/blk: Delete the block-aperture window driver Dan Williams
2022-03-10 7:10 ` Christoph Hellwig
2022-03-10 3:49 ` [PATCH 3/6] nvdimm/namespace: Delete blk namespace consideration in shared paths Dan Williams
2022-03-10 7:10 ` Christoph Hellwig
2022-03-10 3:49 ` [PATCH 4/6] nvdimm/namespace: Delete nd_namespace_blk Dan Williams
2022-03-10 7:10 ` Christoph Hellwig
2022-03-10 3:49 ` [PATCH 5/6] ACPI: NFIT: Remove block aperture support Dan Williams
2022-03-10 7:11 ` Christoph Hellwig
2022-03-10 3:49 ` [PATCH 6/6] nvdimm/region: Delete nd_blk_region infrastructure Dan Williams
2022-03-10 7:11 ` Christoph Hellwig
2022-05-03 3:43 ` Eugene Syromiatnikov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220503034306.GA30980@asgard.redhat.com \
--to=esyr@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=hch@lst.de \
--cc=ldv@strace.io \
--cc=linux-acpi@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=robert.hu@linux.intel.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.