All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Slaby <jslaby@suse.cz>
To: gregkh@linuxfoundation.org
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
	Jiri Slaby <jslaby@suse.cz>
Subject: [PATCH 4/7] serial: pch: remove debug print from pop_tx
Date: Tue,  3 May 2022 10:08:05 +0200	[thread overview]
Message-ID: <20220503080808.28332-3-jslaby@suse.cz> (raw)
In-Reply-To: <20220503080808.28332-1-jslaby@suse.cz>

It makes the code overly complicated for no good reason.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
---
 drivers/tty/serial/pch_uart.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/tty/serial/pch_uart.c b/drivers/tty/serial/pch_uart.c
index 4fcb6c144b54..a90bdff60908 100644
--- a/drivers/tty/serial/pch_uart.c
+++ b/drivers/tty/serial/pch_uart.c
@@ -764,7 +764,7 @@ static bool pop_tx(struct eg20t_port *priv, unsigned int size)
 	struct circ_buf *xmit = &port->state->xmit;
 
 	if (uart_tx_stopped(port))
-		goto pop_tx_end;
+		return false;
 
 	while (!uart_circ_empty(xmit) && count < size) {
 		iowrite8(xmit->buf[xmit->tail], priv->membase + PCH_UART_THR);
@@ -773,10 +773,6 @@ static bool pop_tx(struct eg20t_port *priv, unsigned int size)
 		count++;
 	}
 
-pop_tx_end:
-	dev_dbg(priv->port.dev, "%d characters. Remained %d characters.(%lu)\n",
-		 count, size - count, jiffies);
-
 	return count;
 }
 
-- 
2.36.0


  parent reply	other threads:[~2022-05-03  8:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-03  8:06 [PATCH 0/7] serial: pch: cleanup Jiri Slaby
2022-05-03  8:06 ` [PATCH 1/7] serial: pch: move size check from pop_tx one level up Jiri Slaby
2022-05-03  9:24   ` Andy Shevchenko
2022-05-03  8:08 ` [PATCH 2/7] serial: pch: don't overwrite xmit->buf[0] by x_char Jiri Slaby
2022-05-03  8:08   ` [PATCH 3/7] serial: pch: decomission pch_uart_hal_write() Jiri Slaby
2022-05-03  8:08   ` Jiri Slaby [this message]
2022-05-03  8:08   ` [PATCH 5/7] serial: pch: remove xmit circ_buf size double check Jiri Slaby
2022-05-03  8:08   ` [PATCH 6/7] serial: pch: simplify pop_tx() even more Jiri Slaby
2022-05-03  8:08   ` [PATCH 7/7] serial: pch: inline pop_tx() into handle_tx() Jiri Slaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220503080808.28332-3-jslaby@suse.cz \
    --to=jslaby@suse.cz \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.