From: <Gireesh.Hiremath@in.bosch.com>
To: <m.felsch@pengutronix.de>
Cc: <linux-omap@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-input@vger.kernel.org>,
<bcousson@baylibre.com>, <tony@atomide.com>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <dmitry.torokhov@gmail.com>,
<mkorpershoek@baylibre.com>, <davidgow@google.com>,
<swboyd@chromium.org>, <fengping.yu@mediatek.com>,
<y.oudjana@protonmail.com>, <rdunlap@infradead.org>,
<colin.king@intel.com>, <Gireesh.Hiremath@in.bosch.com>,
<sjoerd.simons@collabora.co.uk>,
<VinayKumar.Shettar@in.bosch.com>,
<Govindaraji.Sivanantham@in.bosch.com>,
<anaclaudia.dias@de.bosch.com>
Subject: Re: [PATCH 2/4] Input: mt-matrix-keypad: Add Bosch mt matrix keypad driver
Date: Wed, 4 May 2022 13:48:17 +0000 [thread overview]
Message-ID: <20220504134817.1490-1-Gireesh.Hiremath@in.bosch.com> (raw)
In-Reply-To: <20220504105254.1576-2-Gireesh.Hiremath@in.bosch.com>
From: Gireesh Hiremath <Gireesh.Hiremath@in.bosch.com>
The existing matric_keypad.c use different gpio line for row and colunm,
where in mt_matrix_kepad.c use same gpio line for row as well as column.
a key can be placed at each intersection of a unique row number
not equal to a unique column and they are diagonally symmetric.
Advantage of this is with existed gpio line we can get more keys
example: in matrix_keypad.c for 5 gpio line possible matrix is 2X3 or 3X2
and maximum possible keys are 6 but
in mt_matrix_kepad.c for same 5 gpio line possible matrix is 5X5 and maximum
possible buttons are 10, below table will discribe that
------------------------------------------------------
|Row\Col |GPIO 0 | GPIO 1 | GPIO 2 | GPIO 3 | GPIO 4 |
------------------------------------------------------
| GPIO 0 | X | KEY_9 | KEY_2 | KEY_3 | KEY_1 |
------------------------------------------------------
| GPIO 1 | KEY_9 | X | KEY_6 | KEY_5 | KEY_0 |
------------------------------------------------------
| GPIO 2 | KEY_2 | KEY_6 | X | KEY_4 | KEY_7 |
------------------------------------------------------
| GPIO 3 | KEY_3 | KEY_5 | KEY_4 | X | KEY_8 |
------------------------------------------------------
| GPIO 4 | KEY_1 | KEY_0 | KEY_7 | KEY_8 | X |
------------------------------------------------------
X - invalid key
KEY_x - preferred key code
both matric_keypad.c and mt_matrix_kepad.c logically operate differently,
my openion is not to merge both.
next prev parent reply other threads:[~2022-05-04 13:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 10:52 [PATCH 1/4] ARM: dts: am335x: Guardian: switch to AM33XX_PADCONF pinmux macro Gireesh.Hiremath
2022-05-04 10:52 ` [PATCH 2/4] Input: mt-matrix-keypad: Add Bosch mt matrix keypad driver Gireesh.Hiremath
2022-05-04 12:10 ` Marco Felsch
2022-05-04 13:48 ` Gireesh.Hiremath [this message]
2022-05-04 14:14 ` Marco Felsch
2022-05-05 8:27 ` Krzysztof Kozlowski
2022-05-04 15:01 ` kernel test robot
2022-05-04 21:56 ` kernel test robot
2022-05-04 10:52 ` [PATCH 3/4] ARM: dts: am335x: Guardian: add keymap to mt matrix keypad Gireesh.Hiremath
2022-05-04 10:52 ` [PATCH 4/4] dt-bindings: input: mt-matrix-keypad: add guardian mt matrix keypad bindings definition Gireesh.Hiremath
2022-05-05 8:29 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220504134817.1490-1-Gireesh.Hiremath@in.bosch.com \
--to=gireesh.hiremath@in.bosch.com \
--cc=Govindaraji.Sivanantham@in.bosch.com \
--cc=VinayKumar.Shettar@in.bosch.com \
--cc=anaclaudia.dias@de.bosch.com \
--cc=bcousson@baylibre.com \
--cc=colin.king@intel.com \
--cc=davidgow@google.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=fengping.yu@mediatek.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=mkorpershoek@baylibre.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=sjoerd.simons@collabora.co.uk \
--cc=swboyd@chromium.org \
--cc=tony@atomide.com \
--cc=y.oudjana@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.