Re: [PATCH net] net: Fix features skip in for_each_netdev_feature()

From: Jakub Kicinski <kuba@kernel.org>
To: Tariq Toukan <tariqt@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>, <netdev@vger.kernel.org>,
	Gal Pressman <gal@nvidia.com>
Subject: Re: [PATCH net] net: Fix features skip in for_each_netdev_feature()
Date: Thu, 5 May 2022 18:30:46 -0700	[thread overview]
Message-ID: <20220505183046.19952bf2@kernel.org> (raw)
In-Reply-To: <20220504080914.1918-1-tariqt@nvidia.com>

On Wed, 4 May 2022 11:09:14 +0300 Tariq Toukan wrote:
> The find_next_netdev_feature() macro gets the "remaining length",
> not bit index.
> Passing "bit - 1" for the following iteration is wrong as it skips
> the adjacent bit. Pass "bit" instead.
> 
> Fixes: 3b89ea9c5902 ("net: Fix for_each_netdev_feature on Big endian")
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
> Reviewed-by: Gal Pressman <gal@nvidia.com>
> ---
>  include/linux/netdev_features.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Hi,
> Please queue to -stable >= v5.0.

You can add the normal Cc: stable tags in networking these days, 
the rules were updated.

But I'll forgo doing that here since your >= 5.0 is incorrect, looks 
like the bad commit got backported to earlier stable branches.
Greg will probably do the right thing based on the Fixes tag, anyway.