Re: [PATCH v5 05/10] iio: accel: bma400: Add separate channel for step counter

From: Jonathan Cameron <jic23@kernel.org>
To: Jagath Jog J <jagathjog1996@gmail.com>
Cc: dan@dlrobertson.com, andy.shevchenko@gmail.com,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 05/10] iio: accel: bma400: Add separate channel for step counter
Date: Sat, 7 May 2022 17:09:29 +0100	[thread overview]
Message-ID: <20220507170929.4fa967d8@jic23-huawei> (raw)
In-Reply-To: <20220505133021.22362-6-jagathjog1996@gmail.com>

On Thu,  5 May 2022 19:00:16 +0530
Jagath Jog J <jagathjog1996@gmail.com> wrote:

> Added channel for step counter which can be enable or disable
> through the sysfs interface.
> 
> Signed-off-by: Jagath Jog J <jagathjog1996@gmail.com>
> ---
>  
> +static int bma400_enable_steps(struct bma400_data *data, int val)
> +{
> +	int ret;
> +
> +	if (data->steps_enabled == val)
> +		return 0;
> +
> +	ret = regmap_update_bits(data->regmap, BMA400_INT_CONFIG1_REG,
> +				 BMA400_STEP_INT_MSK,
> +				 FIELD_PREP(BMA400_STEP_INT_MSK, !!val));
This gives a dubious x & !y warning

So I've changed it to val ? 1 : 0

Jonathan

> +	if (ret)
> +		return ret;
> +	data->steps_enabled = val;
> +	return ret;
> +}