From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Cc: linux-can@vger.kernel.org,
Chandrasekar Ramakrishnan <rcsekar@samsung.com>,
Wolfgang Grandegger <wg@grandegger.com>,
Matthias Schiffer <matthias.schiffer@ew.tq-group.com>,
Chee Hou Ong <chee.houx.ong@intel.com>,
Aman Kumar <aman.kumar@intel.com>,
Pallavi Kumari <kumari.pallavi@intel.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 1/2] Revert "can: m_can: pci: use custom bit timings for Elkhart Lake"
Date: Fri, 13 May 2022 15:10:18 +0200 [thread overview]
Message-ID: <20220513131018.x4xgeqtgamo4pm43@pengutronix.de> (raw)
In-Reply-To: <20220512124144.536850-1-jarkko.nikula@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1643 bytes --]
On 12.05.2022 15:41:43, Jarkko Nikula wrote:
> This reverts commit 0e8ffdf3b86dfd44b651f91b12fcae76c25c453b.
>
> Commit 0e8ffdf3b86d ("can: m_can: pci: use custom bit timings for
> Elkhart Lake") broke the test case using bitrate switching.
>
> ip link set can0 up type can bitrate 500000 dbitrate 4000000 fd on
> ip link set can1 up type can bitrate 500000 dbitrate 4000000 fd on
> candump can0 &
> cangen can1 -I 0x800 -L 64 -e -fb -D 11223344deadbeef55667788feedf00daabbccdd44332211 -n 1 -v -v
>
> Above commit does everything correctly according to the datasheet.
> However datasheet wasn't correct.
>
> I got confirmation from hardware engineers that the actual CAN hardware
> on Intel Elkhart Lake is based on M_CAN version v3.2.0. Datasheet was
> mirroring values from an another specification which was based on earlier
> M_CAN version leading to wrong bit timings.
>
> Therefore revert the commit and switch back to common bit timings.
>
> Fixes: 0e8ffdf3b86d ("can: m_can: pci: use custom bit timings for Elkhart Lake")
> Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
> Reported-by: Chee Hou Ong <chee.houx.ong@intel.com>
> Reported-by: Aman Kumar <aman.kumar@intel.com>
> Reported-by: Pallavi Kumari <kumari.pallavi@intel.com>
> Cc: <stable@vger.kernel.org> # v5.16+
Added to can/testing.
Thanks,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2022-05-13 13:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 12:41 [PATCH 1/2] Revert "can: m_can: pci: use custom bit timings for Elkhart Lake" Jarkko Nikula
2022-05-12 12:41 ` [PATCH 2/2] can: m_can: remove support for custom bit timing, take #2 Jarkko Nikula
2022-05-13 13:10 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220513131018.x4xgeqtgamo4pm43@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=aman.kumar@intel.com \
--cc=chee.houx.ong@intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=kumari.pallavi@intel.com \
--cc=linux-can@vger.kernel.org \
--cc=matthias.schiffer@ew.tq-group.com \
--cc=rcsekar@samsung.com \
--cc=stable@vger.kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.