From: Josh Poimboeuf <jpoimboe@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
llvm@lists.linux.dev, linux-kernel@vger.kernel.org,
kasan-dev@googlegroups.com
Subject: Re: objtool "no non-local symbols" error with tip of tree LLVM
Date: Tue, 17 May 2022 18:24:29 -0700 [thread overview]
Message-ID: <20220518012429.4zqzarvwsraxivux@treble> (raw)
In-Reply-To: <YoPCTEYjoPqE4ZxB@hirez.programming.kicks-ass.net>
On Tue, May 17, 2022 at 05:42:04PM +0200, Peter Zijlstra wrote:
> + for (;;) {
> + symtab_data = elf_getdata(s, symtab_data);
> + if (t)
> + shndx_data = elf_getdata(t, shndx_data);
>
> - sym->idx = symtab->sh.sh_size / sizeof(sym->sym);
> - elf_dirty_reloc_sym(elf, sym);
> + if (!symtab_data) {
> + if (!idx) {
> + void *buf;
I'm confused by whatever this is doing, how is !symtab_data possible,
i.e. why would symtab not have data?
> elf_create_section_symbol(struct elf *elf, struct section *sec)
> {
> struct section *symtab, *symtab_shndx;
> - Elf_Data *shndx_data = NULL;
> - struct symbol *sym;
> - Elf32_Word shndx;
> + Elf32_Word first_non_local, new;
> + struct symbol *sym, *old;
> + int size;
> +
> + if (elf->ehdr.e_ident[EI_CLASS] == ELFCLASS32)
> + size = sizeof(Elf32_Sym);
> + else
> + size = sizeof(Elf64_Sym);
This should probably be called 'entsize' and I think you can just get it
from symtab->sh.sh_entsize.
> + /*
> + * Either way, we added a LOCAL symbol.
> + */
> + symtab->sh.sh_info += 1;
> +
> elf_add_symbol(elf, sym);
Not sure if it matters here, but elf_add_symbol() doesn't set sym->alias
and sym->pv_target, and both of those are unconditionally initialized in
read_symbols(). Should elf_add_symbol() be changed to initialize them?
--
Josh
next prev parent reply other threads:[~2022-05-18 1:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-16 20:47 objtool "no non-local symbols" error with tip of tree LLVM Nathan Chancellor
2022-05-16 21:40 ` Peter Zijlstra
2022-05-16 22:48 ` Nathan Chancellor
2022-05-17 15:33 ` Peter Zijlstra
2022-05-17 15:42 ` Peter Zijlstra
2022-05-17 18:53 ` Nathan Chancellor
2022-05-18 1:24 ` Josh Poimboeuf [this message]
2022-05-18 5:30 ` Peter Zijlstra
2022-05-18 16:17 ` Josh Poimboeuf
2022-05-18 17:14 ` Josh Poimboeuf
2022-05-18 17:25 ` Peter Zijlstra
2022-05-18 18:04 ` Josh Poimboeuf
2022-05-18 7:40 ` Peter Zijlstra
2022-05-18 7:41 ` [PATCH] objtool: Fix symbol creation Peter Zijlstra
2022-05-18 17:36 ` Josh Poimboeuf
2022-05-18 22:10 ` Peter Zijlstra
2022-05-19 9:00 ` [PATCH v2] " Peter Zijlstra
2022-05-19 15:13 ` Josh Poimboeuf
2022-09-07 0:47 ` [PATCH] " Sami Tolvanen
2022-05-19 21:57 ` [tip: objtool/urgent] " tip-bot2 for Peter Zijlstra
2022-05-20 10:53 ` [tip: objtool/core] " tip-bot2 for Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220518012429.4zqzarvwsraxivux@treble \
--to=jpoimboe@kernel.org \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.