All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: Paolo Valente <paolo.valente@linaro.org>
Cc: <linux-block@vger.kernel.org>, Jens Axboe <axboe@kernel.dk>,
	Jan Kara <jack@suse.cz>
Subject: [PATCH 0/4] bfq: Improve waker detection
Date: Thu, 19 May 2022 12:52:28 +0200	[thread overview]
Message-ID: <20220519104621.15456-1-jack@suse.cz> (raw)

Hello,

this patch series restores regression in dbench for large number of processes
that was introduced by c65e6fd460b4 ("bfq: Do not let waker requests skip
proper accounting"). The detailed explanation is in the first patch but the
culprit in the end was that with large number of dbench clients it often
happened that flush worker bfqq replaced jbd2 bfqq as a waker of the bfqq
shared by dbench clients and that resulted in lot of idling and reduced
throughput.

The first two patches in this series improve the waker detection, the other
two are just cleanups I've spotted when working on the code.

I've tested the patches and they don't seem to cause regression for other
workloads.

								Honza

             reply	other threads:[~2022-05-19 10:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-19 10:52 Jan Kara [this message]
2022-05-19 10:52 ` [PATCH 1/4] bfq: Relax waker detection for shared queues Jan Kara
2022-05-19 10:52 ` [PATCH 2/4] bfq: Allow current waker to defend against a tentative one Jan Kara
2022-05-19 10:52 ` [PATCH 3/4] bfq: Remove superfluous conversion from RQ_BIC() Jan Kara
2022-05-19 10:52 ` [PATCH 4/4] bfq: Remove bfq_requeue_request_body() Jan Kara
2022-05-19 12:52 ` [PATCH 0/4] bfq: Improve waker detection Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220519104621.15456-1-jack@suse.cz \
    --to=jack@suse.cz \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=paolo.valente@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.