Re: [PATCH] rtc: rzn1: Fix error code in probe

From: Dan Carpenter <dan.carpenter@oracle.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Michel Pollet <michel.pollet@bp.renesas.com>,
	Alessandro Zummo <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] rtc: rzn1: Fix error code in probe
Date: Thu, 19 May 2022 17:26:46 +0300	[thread overview]
Message-ID: <20220519142646.GA23160@kadam> (raw)
In-Reply-To: <20220519160821.14230810@xps-13>

On Thu, May 19, 2022 at 04:08:21PM +0200, Miquel Raynal wrote:
> Hi Dan,
> 
> dan.carpenter@oracle.com wrote on Thu, 19 May 2022 16:56:19 +0300:
> 
> > There is a copy and paste error so this code returns the wrong variable.
> > 
> > Fixes: deeb4b5393e1 ("rtc: rzn1: Add new RTC driver")
> 
> The Fixes here will point to an unknown id once pulled by Linus.

No, it shouldn't be an issue.

I'm assuming based on the S-o-b tags that this goes through Alexandre's
tree.  The hash will stay the same unless Alexandre rebases.

When a maintainer rebases then it's their responsibility to update the
Fixes tags.  Most likely the maintainer just going to fold the fixes
patches into the original patch so it's a moot issue.  There are
automated checks run on linux-next for incorrect Fixes tags so, you
know, don't rebase and then push immediately; first let the autobuilders
check for stuff like this.

regards,
dan carpenter