From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: alsa-devel@alsa-project.org,
Lucas Tanure <tanureal@opensource.cirrus.com>,
patches@opensource.cirrus.com,
Liam Girdwood <lgirdwood@gmail.com>,
David Rhodes <david.rhodes@cirrus.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
Mark Brown <broonie@kernel.org>,
kernel@pengutronix.de, James Schulman <james.schulman@cirrus.com>
Subject: Re: [PATCH] ASoC: cs35l45: Make bmc150_magn_remove() return void
Date: Fri, 20 May 2022 14:47:38 +0000 [thread overview]
Message-ID: <20220520144738.GM38351@ediswmail.ad.cirrus.com> (raw)
In-Reply-To: <20220520135740.770801-1-u.kleine-koenig@pengutronix.de>
On Fri, May 20, 2022 at 03:57:40PM +0200, Uwe Kleine-König wrote:
> cs35l45_remove() always returns zero. Make it return no value which
> makes it easier to see in the callers that there is no error to handle.
>
> Also the return value of i2c driver remove callbacks is ignored anyway.
> This prepares making i2c remove callbacks return void, too.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
The subject line needs fixed up but otherwise I think the patch
looks good.
Thanks,
Charles
next prev parent reply other threads:[~2022-05-20 14:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 13:57 [PATCH] ASoC: cs35l45: Make bmc150_magn_remove() return void Uwe Kleine-König
2022-05-20 14:47 ` Charles Keepax [this message]
2022-05-20 17:33 ` [PATCH v2] ASoC: cs35l45: Make cs35l45_remove() " Uwe Kleine-König
2022-05-23 8:57 ` Richard Fitzgerald
2022-05-25 9:59 ` Charles Keepax
2022-06-07 10:45 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220520144738.GM38351@ediswmail.ad.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=david.rhodes@cirrus.com \
--cc=james.schulman@cirrus.com \
--cc=kernel@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=patches@opensource.cirrus.com \
--cc=rf@opensource.cirrus.com \
--cc=tanureal@opensource.cirrus.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.