From: Dave Chinner <david@fromorbit.com>
To: Zorro Lang <zlang@kernel.org>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH 07/12] xfs/148: fix failure from bad shortform size assumptions
Date: Sun, 22 May 2022 09:22:28 +1000 [thread overview]
Message-ID: <20220521232228.GA2306852@dread.disaster.area> (raw)
In-Reply-To: <20220520073438.bof3lpok2wx6krls@zlang-mailbox>
On Fri, May 20, 2022 at 03:34:38PM +0800, Zorro Lang wrote:
> On Tue, May 17, 2022 at 05:01:06PM +1000, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> > @@ -41,9 +41,12 @@ test_names=("something" "$nullstr" "$slashstr" "another")
> > rm -f $imgfile $imgfile.old
> >
> > # Format image file w/o crcs so we can sed the image file
> > +# We need to use 512 byte inodes to ensure the attr forks remain in short form
> > +# even when security xattrs are present so we are always doing name matches on
> > +# lookup and not name hash compares as leaf/node forms will do.
> > $XFS_IO_PROG -f -c 'truncate 40m' $imgfile
> > loopdev=$(_create_loop_device $imgfile)
> > -MKFS_OPTIONS="-m crc=0" _mkfs_dev $loopdev >> $seqres.full
> > +MKFS_OPTIONS="-m crc=0 -i size=512" _mkfs_dev $loopdev >> $seqres.full
>
> It's good to me, although I'm wondering why you didn't choose to use
> $SELINUX_MOUNT_OPTIONS [1]. Anyway, extending inode size can help too.
Because if we are running under any other context that adds xattrs
to the files by defaults (e.g. default acls, other LSMs, etc) will
cause it to fail the same way.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2022-05-21 23:22 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 7:00 [PATCH 00/13 V2] fstests: fixes and more fixes Dave Chinner
2022-05-17 7:01 ` [PATCH 01/12] fstests: filter quota warnings Dave Chinner
2022-05-17 7:01 ` [PATCH 02/12] xfs/122: add attribute log formats to test output Dave Chinner
2022-05-17 7:01 ` [PATCH 03/12] xfs/348: golden output is not correct Dave Chinner
2022-05-17 7:01 ` [PATCH 04/12] fstests: fix group list generation for whacky test names Dave Chinner
2022-05-19 18:52 ` Darrick J. Wong
2022-05-20 8:36 ` Zorro Lang
2022-05-20 8:54 ` Zorro Lang
2022-05-20 9:25 ` Zorro Lang
2022-05-20 16:23 ` Darrick J. Wong
2022-05-21 0:27 ` Zorro Lang
2022-05-17 7:01 ` [PATCH 05/12] README: document _begin_fstests better Dave Chinner
2022-05-19 23:13 ` Darrick J. Wong
2022-05-20 1:58 ` Dave Chinner
2022-05-20 2:02 ` Darrick J. Wong
2022-05-20 5:23 ` Zorro Lang
2022-05-20 5:42 ` Dave Chinner
2022-05-20 6:16 ` Zorro Lang
2022-05-17 7:01 ` [PATCH 06/12] xfs/148: make test debuggable Dave Chinner
2022-05-19 18:55 ` Darrick J. Wong
2022-05-17 7:01 ` [PATCH 07/12] xfs/148: fix failure from bad shortform size assumptions Dave Chinner
2022-05-20 7:34 ` Zorro Lang
2022-05-21 23:22 ` Dave Chinner [this message]
2022-05-17 7:01 ` [PATCH 08/12] generic/081: don't run on DAX capable devices Dave Chinner
2022-05-18 5:11 ` Dave Chinner
2022-05-17 7:01 ` [PATCH 12/12] xfs/191: remove broken test Dave Chinner
2022-05-19 18:55 ` Darrick J. Wong
2022-05-17 7:49 ` [PATCH 00/13 V2] fstests: fixes and more fixes Dave Chinner
2022-05-17 8:24 ` Zorro Lang
2022-05-17 21:39 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220521232228.GA2306852@dread.disaster.area \
--to=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.