From: David Sterba <dsterba@suse.cz>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: Stefan Roesch <shr@fb.com>, Chris Mason <clm@fb.com>,
Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>, Nick Terrell <terrelln@fb.com>,
linux-btrfs@vger.kernel.org, kernel-janitors@vger.kernel.org,
Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH -next] btrfs: sysfs: fix return value check in btrfs_force_chunk_alloc_s()
Date: Wed, 8 Jun 2022 23:17:05 +0200 [thread overview]
Message-ID: <20220608211705.GQ20633@twin.jikos.cz> (raw)
In-Reply-To: <20220608021252.990374-1-weiyongjun1@huawei.com>
On Wed, Jun 08, 2022 at 02:12:52AM +0000, Wei Yongjun wrote:
> In case of error, the function btrfs_start_transaction() returns
> ERR_PTR() and never returns NULL. The NULL test in the return value
> check should be replaced with IS_ERR().
>
> Fixes: 46e1bce0ac34 ("btrfs: sysfs: add force_chunk_alloc trigger to force allocation")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Thanks, fix folded to the patch as it's still in the development branch.
prev parent reply other threads:[~2022-06-08 21:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-08 2:12 [PATCH -next] btrfs: sysfs: fix return value check in btrfs_force_chunk_alloc_s() Wei Yongjun
2022-06-08 21:17 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220608211705.GQ20633@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=hulkci@huawei.com \
--cc=josef@toxicpanda.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=shr@fb.com \
--cc=terrelln@fb.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.