From: Andrew Morton <akpm@linux-foundation.org>
To: Miaohe Lin <linmiaohe@huawei.com>
Cc: <aarcange@redhat.com>, <willy@infradead.org>, <vbabka@suse.cz>,
<dhowells@redhat.com>, <neilb@suse.de>, <apopple@nvidia.com>,
<david@redhat.com>, <surenb@google.com>, <peterx@redhat.com>,
<linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/7] mm/khugepaged: remove unneeded shmem_huge_enabled() check
Date: Sat, 11 Jun 2022 13:33:36 -0700 [thread overview]
Message-ID: <20220611133336.b582edd4c2c2df15f5561d2b@linux-foundation.org> (raw)
In-Reply-To: <20220611084731.55155-2-linmiaohe@huawei.com>
On Sat, 11 Jun 2022 16:47:25 +0800 Miaohe Lin <linmiaohe@huawei.com> wrote:
> If we reach here, hugepage_vma_check() has already made sure that hugepage
> is enabled for shmem. Remove this duplicated check.
I updated this to
If we reach here, hugepage_vma_check() has already made sure that hugepage
is enabled for shmem, via its call to hugepage_vma_check(). Remove this
duplicated check.
next prev parent reply other threads:[~2022-06-11 20:33 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-11 8:47 [PATCH 0/7] A few cleanup patches for khugepaged Miaohe Lin
2022-06-11 8:47 ` [PATCH 1/7] mm/khugepaged: remove unneeded shmem_huge_enabled() check Miaohe Lin
2022-06-11 20:33 ` Andrew Morton [this message]
2022-06-13 1:48 ` Miaohe Lin
2022-06-13 18:02 ` Andrew Morton
2022-06-15 0:13 ` Zach O'Keefe
2022-06-15 17:35 ` Yang Shi
2022-06-11 8:47 ` [PATCH 2/7] mm/khugepaged: stop swapping in page when VM_FAULT_RETRY occurs Miaohe Lin
2022-06-15 15:14 ` Zach O'Keefe
2022-06-15 17:51 ` Yang Shi
2022-06-16 6:08 ` Miaohe Lin
2022-06-15 17:49 ` Yang Shi
2022-06-16 6:40 ` Miaohe Lin
2022-06-16 15:46 ` Yang Shi
2022-06-11 8:47 ` [PATCH 3/7] mm/khugepaged: trivial typo and codestyle cleanup Miaohe Lin
2022-06-15 0:23 ` Zach O'Keefe
2022-06-15 17:53 ` Yang Shi
2022-06-11 8:47 ` [PATCH 4/7] mm/khugepaged: minor cleanup for collapse_file Miaohe Lin
2022-06-15 15:54 ` Zach O'Keefe
2022-06-15 18:18 ` Yang Shi
2022-06-16 6:10 ` Miaohe Lin
2022-06-11 8:47 ` [PATCH 5/7] mm/khugepaged: use helper macro __ATTR_RW Miaohe Lin
2022-06-15 0:29 ` Zach O'Keefe
2022-06-15 7:48 ` Miaohe Lin
2022-06-15 21:28 ` Yang Shi
2022-06-16 7:07 ` Miaohe Lin
2022-06-16 15:48 ` Yang Shi
2022-06-11 8:47 ` [PATCH 6/7] mm/khugepaged: remove unneeded return value of khugepaged_add_pte_mapped_thp() Miaohe Lin
2022-06-15 0:19 ` Zach O'Keefe
2022-06-15 21:35 ` Yang Shi
2022-06-11 8:47 ` [PATCH 7/7] mm/khugepaged: try to free transhuge swapcache when possible Miaohe Lin
2022-06-15 17:13 ` Zach O'Keefe
2022-06-16 3:38 ` Mika Penttilä
2022-06-16 7:33 ` Miaohe Lin
2022-06-15 23:58 ` Yang Shi
2022-06-16 7:42 ` Miaohe Lin
2022-06-16 15:53 ` Yang Shi
2022-06-17 2:26 ` Miaohe Lin
2022-06-17 16:35 ` Yang Shi
2022-06-18 3:13 ` Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220611133336.b582edd4c2c2df15f5561d2b@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aarcange@redhat.com \
--cc=apopple@nvidia.com \
--cc=david@redhat.com \
--cc=dhowells@redhat.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=neilb@suse.de \
--cc=peterx@redhat.com \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.