From: Christoph Hellwig <hch@lst.de>
To: axboe@kernel.dk
Cc: shinichiro.kawasaki@wdc.com, dan.j.williams@intel.com,
yukuai3@huawei.com, ming.lei@redhat.com,
linux-block@vger.kernel.org
Subject: fix tag freeing use after free and debugfs name reuse
Date: Tue, 14 Jun 2022 09:48:23 +0200 [thread overview]
Message-ID: <20220614074827.458955-1-hch@lst.de> (raw)
Hi all,
the first patch fixes a use after free, and the others deal with debugfs
name reuse that spews warnings and makes debugfs use impossible for
quickly reused gendisk instances. Both of those are rooted in sloppy
life time rules for block device tear down.
Compared to the previous separate postings this adds a missing queue
quiesce and documents debugfs_mutex better.
Diffstat:
block/blk-core.c | 13 -------------
block/blk-mq-debugfs.c | 29 ++++++++++++++++++-----------
block/blk-mq-debugfs.h | 10 ----------
block/blk-mq-sched.c | 11 +++++++++++
block/blk-rq-qos.c | 2 --
block/blk-rq-qos.h | 7 ++++++-
block/blk-sysfs.c | 30 ++++++++++++++----------------
block/genhd.c | 42 ++++++++++++------------------------------
include/linux/blkdev.h | 8 ++++----
kernel/trace/blktrace.c | 3 ---
10 files changed, 65 insertions(+), 90 deletions(-)
next reply other threads:[~2022-06-14 7:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 7:48 Christoph Hellwig [this message]
2022-06-14 7:48 ` [PATCH 1/4] block: disable the elevator int del_gendisk Christoph Hellwig
2022-06-14 8:23 ` Ming Lei
2022-06-14 8:34 ` Christoph Hellwig
2022-06-14 11:27 ` Ming Lei
2022-06-17 12:50 ` Jens Axboe
2022-06-17 13:26 ` Christoph Hellwig
2022-06-17 13:27 ` Jens Axboe
2022-06-14 7:48 ` [PATCH 2/4] block: serialize all debugfs operations using q->debugfs_mutex Christoph Hellwig
2022-06-14 7:48 ` [PATCH 3/4] block: remove per-disk debugfs files in blk_unregister_queue Christoph Hellwig
2022-06-14 7:48 ` [PATCH 4/4] block: freeze the queue earlier in del_gendisk Christoph Hellwig
2022-07-08 5:41 ` REGRESSION: " Logan Gunthorpe
2022-07-08 6:01 ` Christoph Hellwig
2022-07-08 15:55 ` Logan Gunthorpe
2022-07-09 8:17 ` Christoph Hellwig
2022-07-11 3:33 ` Logan Gunthorpe
2022-07-11 4:33 ` Christoph Hellwig
2022-06-17 13:31 ` fix tag freeing use after free and debugfs name reuse Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220614074827.458955-1-hch@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=dan.j.williams@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=shinichiro.kawasaki@wdc.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.