All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vincent Fu <vincent.fu@samsung.com>
To: "axboe@kernel.dk" <axboe@kernel.dk>,
	"fio@vger.kernel.org" <fio@vger.kernel.org>
Cc: Vincent Fu <vincent.fu@samsung.com>
Subject: [PATCH 0/5] Latency cleanups
Date: Tue, 14 Jun 2022 15:58:29 +0000	[thread overview]
Message-ID: <20220614155822.307771-1-vincent.fu@samsung.com> (raw)
In-Reply-To: CGME20220614155830uscas1p1e1d6595b29fb6960b405d5b295a32ffc@uscas1p1.samsung.com

Jens, here are a few latency cleanup patches. The main improvement is to
avoid recording issue_time twice for the ioengines that record
issue_time themselves when their commit hook is called. Recording
issue_time twice underestimates clat since the first issue_time value is
used for slat and then the later second issue_time is used when
calculating clat.

I'm not able to test the rdma and librpma ioengines but the fix for
libaio and io_uring appears to work properly.

Vincent Fu (5):
  ioengines: add helper for trims with async ioengines
  ioengines: don't record issue_time if ioengines already do it
  HOWTO: improve description of latency measures
  ioengines: update last_issue if we set issue_time
  ioengines: clean up latency accounting for 3 ioengines

 HOWTO.rst               | 29 ++++++++++++++++-----------
 engines/io_uring.c      | 13 ++++++++++--
 engines/libaio.c        |  9 ++++++++-
 engines/librpma_apm.c   |  2 +-
 engines/librpma_fio.c   |  9 ++++++++-
 engines/librpma_gpspm.c |  2 +-
 engines/rdma.c          |  9 ++++++++-
 ioengines.c             | 44 ++++++++++++++++++++++++-----------------
 ioengines.h             |  2 ++
 9 files changed, 83 insertions(+), 36 deletions(-)

-- 
2.25.1

       reply	other threads:[~2022-06-14 15:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20220614155830uscas1p1e1d6595b29fb6960b405d5b295a32ffc@uscas1p1.samsung.com>
2022-06-14 15:58 ` Vincent Fu [this message]
     [not found]   ` <CGME20220614155830uscas1p15aaa5d3bc8eec3da42c78a48520c6dd9@uscas1p1.samsung.com>
2022-06-14 15:58     ` [PATCH 2/5] ioengines: don't record issue_time if ioengines already do it Vincent Fu
2022-06-15 15:26       ` Nick Neumann
2022-06-15 17:06         ` Vincent Fu
2022-06-15 17:51           ` Nick Neumann
     [not found]   ` <CGME20220614155831uscas1p2312cb623924e5df60abefb210affa1f4@uscas1p2.samsung.com>
2022-06-14 15:58     ` [PATCH 3/5] HOWTO: improve description of latency measures Vincent Fu
     [not found]   ` <CGME20220614155831uscas1p12c7b262538a47a417dc783a45e8df049@uscas1p1.samsung.com>
2022-06-14 15:58     ` [PATCH 4/5] ioengines: update last_issue if we set issue_time Vincent Fu
     [not found]   ` <CGME20220614155830uscas1p2586c5e612430bdd2ce455a1081ce08e4@uscas1p2.samsung.com>
2022-06-14 15:58     ` [PATCH 1/5] ioengines: add helper for trims with async ioengines Vincent Fu
     [not found]   ` <CGME20220614155831uscas1p16ab7450c13a1587f2058617130f4f122@uscas1p1.samsung.com>
2022-06-14 15:58     ` [PATCH 5/5] ioengines: clean up latency accounting for 3 ioengines Vincent Fu
2022-06-15 21:30   ` [PATCH 0/5] Latency cleanups Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220614155822.307771-1-vincent.fu@samsung.com \
    --to=vincent.fu@samsung.com \
    --cc=axboe@kernel.dk \
    --cc=fio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.