From: Christoph Hellwig <hch@lst.de>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: Christoph Hellwig <hch@lst.de>, David Sterba <dsterba@suse.com>,
Josef Bacik <josef@toxicpanda.com>, Qu Wenruo <wqu@suse.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 4/5] btrfs: remove the raid56_parity_{write,recover} return value
Date: Thu, 16 Jun 2022 08:36:18 +0200 [thread overview]
Message-ID: <20220616063618.GB5608@lst.de> (raw)
In-Reply-To: <e2d5e49f-28da-95de-20b6-b29c0ce00cf9@gmx.com>
On Thu, Jun 16, 2022 at 09:06:50AM +0800, Qu Wenruo wrote:
>> But at this branch, we don't yet have called
>> `btrfs_bio_counter_inc_noblocked()`.
>>
>> Wouldn't this cause underflow?
>>
>>> rbio->operation = BTRFS_RBIO_WRITE;
>>> rbio_add_bio(rbio, bio);
>>>
>>> - btrfs_bio_counter_inc_noblocked(fs_info);
>
> And this line is removed completely, any reason for the removal?
This is all part of making these functions consume the bio counter
as documented in the changelog. But I guess splitting that from
the pure prototype change should help to able to understand the
changes, so I'll do that for the next version.
next prev parent reply other threads:[~2022-06-16 6:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-15 15:15 cleanup btrfs bio submission Christoph Hellwig
2022-06-15 15:15 ` [PATCH 1/5] btrfs: remove a bunch of pointles stripe_len arguments Christoph Hellwig
2022-06-15 21:28 ` Qu Wenruo
2022-06-17 9:53 ` Johannes Thumshirn
2022-06-15 15:15 ` [PATCH 2/5] btrfs: return proper mapped length for RAID56 profiles in __btrfs_map_block() Christoph Hellwig
2022-06-17 9:54 ` Johannes Thumshirn
2022-06-15 15:15 ` [PATCH 3/5] btrfs: remove the btrfs_map_bio return value Christoph Hellwig
2022-06-15 16:59 ` Boris Burkov
2022-06-15 17:10 ` Christoph Hellwig
2022-06-16 1:02 ` Qu Wenruo
2022-06-17 9:55 ` Johannes Thumshirn
2022-06-15 15:15 ` [PATCH 4/5] btrfs: remove the raid56_parity_{write,recover} " Christoph Hellwig
2022-06-16 1:05 ` Qu Wenruo
2022-06-16 1:06 ` Qu Wenruo
2022-06-16 6:36 ` Christoph Hellwig [this message]
2022-06-16 9:53 ` Qu Wenruo
2022-06-16 10:54 ` Christoph Hellwig
2022-06-15 15:15 ` [PATCH 5/5] btrfs: remove bioc->stripes_pending Christoph Hellwig
2022-06-15 18:16 ` Boris Burkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220616063618.GB5608@lst.de \
--to=hch@lst.de \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.