From: Mike Christie <michael.christie@oracle.com>
To: lduncan@suse.com, cleech@redhat.com, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org, jejb@linux.ibm.com
Cc: Mike Christie <michael.christie@oracle.com>, Wu Bo <wubo40@huawei.com>
Subject: [PATCH 5/9] scsi: iscsi_tcp: Drop target_alloc use
Date: Thu, 16 Jun 2022 17:45:53 -0500 [thread overview]
Message-ID: <20220616224557.115234-6-michael.christie@oracle.com> (raw)
In-Reply-To: <20220616224557.115234-1-michael.christie@oracle.com>
For software iSCSI, we do a session per host so there is no need to set the
target's can_queue since it's the same as the host one. Setting it just
results in extra atomic checks in the main I/O path.
Reviewed-by: Lee Duncan <lduncan@suse.com>
Reviewed-by: Wu Bo <wubo40@huawei.com>
Signed-off-by: Mike Christie <michael.christie@oracle.com>
---
drivers/scsi/iscsi_tcp.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c
index df38c6c10aa9..2cfd40cf2859 100644
--- a/drivers/scsi/iscsi_tcp.c
+++ b/drivers/scsi/iscsi_tcp.c
@@ -1042,7 +1042,6 @@ static struct scsi_host_template iscsi_sw_tcp_sht = {
.eh_target_reset_handler = iscsi_eh_recover_target,
.dma_boundary = PAGE_SIZE - 1,
.slave_configure = iscsi_sw_tcp_slave_configure,
- .target_alloc = iscsi_target_alloc,
.proc_name = "iscsi_tcp",
.this_id = -1,
.track_queue_depth = 1,
--
2.25.1
next prev parent reply other threads:[~2022-06-16 22:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 22:45 [PATCH 0/9] iscsi features for 5.20 Mike Christie
2022-06-16 22:45 ` [PATCH 1/9] scsi: iscsi: Rename iscsi_conn_queue_work() Mike Christie
2022-06-16 22:45 ` [PATCH 2/9] scsi: iscsi: Add recv workqueue helpers Mike Christie
2022-06-16 22:45 ` [PATCH 3/9] scsi: iscsi: Run recv path from workqueue Mike Christie
2022-06-16 22:45 ` [PATCH 4/9] scsi: iscsi_tcp: Tell net when there's more data Mike Christie
2022-06-16 22:45 ` Mike Christie [this message]
2022-06-16 22:45 ` [PATCH 6/9] scsi: iscsi: Remove unneeded task state check Mike Christie
2022-06-16 22:45 ` [PATCH 7/9] scsi: iscsi: Remove iscsi_get_task back_lock requirement Mike Christie
2022-06-16 22:45 ` [PATCH 8/9] scsi: iscsi: Try to avoid taking back_lock in xmit path Mike Christie
2022-06-16 22:45 ` [PATCH 9/9] scsi: libiscsi: Improve conn_send_pdu API Mike Christie
2022-06-22 1:20 ` [PATCH 0/9] iscsi features for 5.20 Martin K. Petersen
2022-06-28 3:24 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220616224557.115234-6-michael.christie@oracle.com \
--to=michael.christie@oracle.com \
--cc=cleech@redhat.com \
--cc=jejb@linux.ibm.com \
--cc=lduncan@suse.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=wubo40@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.