From: Dave Chinner <david@fromorbit.com>
To: An Long <lan@suse.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH v2 0/2] Fix input value to _scratch_mkfs_sized
Date: Fri, 17 Jun 2022 13:58:36 +1000 [thread overview]
Message-ID: <20220617035836.GZ1098723@dread.disaster.area> (raw)
In-Reply-To: <20220616043845.14320-1-lan@suse.com>
On Thu, Jun 16, 2022 at 12:38:43PM +0800, An Long wrote:
> Function _scratch_mkfs_sized cannot recognize the size descriptor.
>
> For example, we set MKFS_OPTIONS="-b 4k" and then run generic/416 on
> ext4, will fail with "mkfs.ext4: invalid block size - 4".
So isn't the correct fix for this to use the correct format in
MKFS_OPTIONS? ie. "-b 4096"?
i.e. why do we need ito add code to fix something that the user must
specify themselves and could easily just use an integer to begin
with?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2022-06-17 3:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 4:38 [PATCH v2 0/2] Fix input value to _scratch_mkfs_sized An Long
2022-06-16 4:38 ` [PATCH v2 1/2] common/rc: add _parse_size_string An Long
2022-06-16 15:25 ` Gabriel Krisman Bertazi
2022-06-17 6:45 ` Long An
2022-06-16 4:38 ` [PATCH v2 2/2] common/rc: fix input value to _scratch_mkfs_sized An Long
2022-06-17 3:58 ` Dave Chinner [this message]
2022-06-17 7:03 ` [PATCH v2 0/2] Fix " Long An
2022-06-17 17:52 ` Zorro Lang
2022-06-17 22:24 ` Dave Chinner
2022-06-18 3:14 ` Zorro Lang
2022-06-20 23:12 ` Dave Chinner
2022-06-21 4:05 ` Zorro Lang
2022-06-21 4:25 ` Long An
2022-06-21 4:40 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220617035836.GZ1098723@dread.disaster.area \
--to=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=lan@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.