From: HighW4y2H3ll <huzh@nyu.edu>
To: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: HighW4y2H3ll <huzh@nyu.edu>, linux-kernel@vger.kernel.org
Subject: [PATCH] Fix use of uninitialized variable in rts5261_init_from_hw, when efuse_valid == 1.
Date: Fri, 17 Jun 2022 00:47:55 -0400 [thread overview]
Message-ID: <20220617044755.37535-1-huzh@nyu.edu> (raw)
Signed-off-by: zhenghao hu <huzh@nyu.edu>
---
drivers/misc/cardreader/rts5261.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/cardreader/rts5261.c b/drivers/misc/cardreader/rts5261.c
index 749cc5a46d13..f22634b14dc8 100644
--- a/drivers/misc/cardreader/rts5261.c
+++ b/drivers/misc/cardreader/rts5261.c
@@ -403,7 +403,7 @@ static void rts5261_init_from_hw(struct rtsx_pcr *pcr)
setting_reg1 = PCR_SETTING_REG4;
setting_reg2 = PCR_SETTING_REG5;
}
- } else if (efuse_valid == 0) {
+ } else {
// default
setting_reg1 = PCR_SETTING_REG1;
setting_reg2 = PCR_SETTING_REG2;
--
2.35.1
next reply other threads:[~2022-06-17 5:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-17 4:47 HighW4y2H3ll [this message]
2022-06-17 6:33 ` [PATCH] Fix use of uninitialized variable in rts5261_init_from_hw, when efuse_valid == 1 Greg Kroah-Hartman
2022-06-17 18:40 ` Nathan Chancellor
2022-06-17 19:01 ` Zhenghao Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220617044755.37535-1-huzh@nyu.edu \
--to=huzh@nyu.edu \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.