From: Jan Kara <jack@suse.cz>
To: Ritesh Harjani <ritesh.list@gmail.com>
Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Jan Kara <jack@suse.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christoph Hellwig <hch@lst.de>, kernel test robot <lkp@intel.com>
Subject: Re: [PATCHv2 2/4] fs/ntfs: Drop useless return value of submit_bh from ntfs_submit_bh_for_read
Date: Mon, 20 Jun 2022 11:49:09 +0200 [thread overview]
Message-ID: <20220620094909.rksiex5yv3xnrsf4@quack3.lan> (raw)
In-Reply-To: <f53e945837f78c042bee5337352e2fa216d71a5a.1655715329.git.ritesh.list@gmail.com>
On Mon 20-06-22 14:34:35, Ritesh Harjani wrote:
> submit_bh always returns 0. This patch drops the useless return value of
> submit_bh from ntfs_submit_bh_for_read(). Once all of submit_bh callers are
> cleaned up, we can make it's return type as void.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Ritesh Harjani <ritesh.list@gmail.com>
Looks good. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/ntfs/file.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ntfs/file.c b/fs/ntfs/file.c
> index a8abe2296514..2389bfa654a2 100644
> --- a/fs/ntfs/file.c
> +++ b/fs/ntfs/file.c
> @@ -532,12 +532,12 @@ static inline int __ntfs_grab_cache_pages(struct address_space *mapping,
> goto out;
> }
>
> -static inline int ntfs_submit_bh_for_read(struct buffer_head *bh)
> +static inline void ntfs_submit_bh_for_read(struct buffer_head *bh)
> {
> lock_buffer(bh);
> get_bh(bh);
> bh->b_end_io = end_buffer_read_sync;
> - return submit_bh(REQ_OP_READ, 0, bh);
> + submit_bh(REQ_OP_READ, 0, bh);
> }
>
> /**
> --
> 2.35.3
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2022-06-20 9:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 9:04 [PATCHv2 0/4] submit_bh: Drop unnecessary return values and API users Ritesh Harjani
2022-06-20 9:04 ` [PATCHv2 1/4] jbd2: Drop useless return value of submit_bh Ritesh Harjani
2022-06-20 9:04 ` [PATCHv2 2/4] fs/ntfs: Drop useless return value of submit_bh from ntfs_submit_bh_for_read Ritesh Harjani
2022-06-20 9:10 ` Ritesh Harjani
2022-06-20 9:49 ` Jan Kara [this message]
2022-06-21 6:34 ` Christoph Hellwig
2022-06-20 9:04 ` [PATCHv2 3/4] fs/buffer: Drop useless return value of submit_bh Ritesh Harjani
2022-06-20 9:04 ` [PATCHv2 4/4] fs/buffer: Make submit_bh & submit_bh_wbc return type as void Ritesh Harjani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220620094909.rksiex5yv3xnrsf4@quack3.lan \
--to=jack@suse.cz \
--cc=hch@lst.de \
--cc=jack@suse.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=ritesh.list@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.