From: Amir Goldstein <amir73il@gmail.com>
To: Zorro Lang <zlang@redhat.com>
Cc: "Darrick J . Wong" <darrick.wong@oracle.com>,
Dave Chinner <david@fromorbit.com>,
fstests@vger.kernel.org
Subject: [PATCH v2 0/3] aborted fstests may leave frozen fs behind
Date: Tue, 21 Jun 2022 20:37:26 +0300 [thread overview]
Message-ID: <20220621173729.2135249-1-amir73il@gmail.com> (raw)
Zorro,
As discussed on v1, this series fixes cleanup routines of
freeze tests without adding auto-cleanup in check.
I also took a closer look at some test cleanups and handled the
kill of background processes after unfreeze.
I tested that all the tests in the 'freeze' group that I modified
run to completion with no regressions.
I did not try to interrupt all the rest of the tests, because
interrupting a test at exact time that it is frozen is quite hard.
I did test that interrupting xfs/517 several times did not leave the fs
frozen. Before the changes, it was rather easy to get it to leave a
frozen fs behind, because the freeze_loop() keeps the fs frozen around
half of the time that the test is running.
Thanks,
Amir.
Changes since v1:
- Remove auto-cleanup in check
- Add more kill+wait in cleanups where needed
- Change the cleanup routines of the freeze_loops
Amir Goldstein (3):
fstests: add missing _require_freeze() to tests
fstests: unfreeze fs on cleanup routines
xfs/{422,517}: kill background jobs on test termination
tests/generic/068 | 14 ++++++++++----
tests/generic/085 | 3 +++
tests/generic/280 | 13 ++++++++++++-
tests/generic/390 | 8 +++++++-
tests/generic/459 | 2 ++
tests/generic/491 | 9 +++++++++
tests/xfs/011 | 3 ++-
tests/xfs/119 | 10 ++++++++++
tests/xfs/297 | 11 +++++++++++
tests/xfs/318 | 6 ++++--
tests/xfs/325 | 6 ++++--
tests/xfs/422 | 35 ++++++++++++++++++++++++++++++++---
tests/xfs/438 | 4 +++-
tests/xfs/517 | 27 ++++++++++++++++++++++++---
14 files changed, 133 insertions(+), 18 deletions(-)
--
2.25.1
next reply other threads:[~2022-06-21 17:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 17:37 Amir Goldstein [this message]
2022-06-21 17:37 ` [PATCH v2 1/3] fstests: add missing _require_freeze() to tests Amir Goldstein
2022-06-24 15:26 ` Zorro Lang
2022-06-21 17:37 ` [PATCH v2 2/3] fstests: unfreeze fs on cleanup routines Amir Goldstein
2022-06-24 16:06 ` Zorro Lang
2022-06-21 17:37 ` [PATCH v2 3/3] xfs/{422,517}: kill background jobs on test termination Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220621173729.2135249-1-amir73il@gmail.com \
--to=amir73il@gmail.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.