From: Zorro Lang <zlang@redhat.com>
To: David Disseldorp <ddiss@suse.de>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH 3/6] report: drop unused _xunit_make_section_report parameter
Date: Wed, 22 Jun 2022 12:37:18 +0800 [thread overview]
Message-ID: <20220622043718.pcdgu6n2mhbijv4x@zlang-mailbox> (raw)
In-Reply-To: <20220620192934.21694-4-ddiss@suse.de>
On Mon, Jun 20, 2022 at 09:29:31PM +0200, David Disseldorp wrote:
> Signed-off-by: David Disseldorp <ddiss@suse.de>
> ---
> common/report | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/report b/common/report
> index 6cac71fc..bf05afa9 100644
> --- a/common/report
> +++ b/common/report
> @@ -152,7 +152,7 @@ _make_section_report()
> for report in $REPORT_LIST; do
> case "$report" in
> "xunit")
> - _xunit_make_section_report "$test_status"
> + _xunit_make_section_report
Hmm... I checked the history about _xunit_make_section_report, it was brought in
by f9fde7db2fa5 ("report: Add xunit format report generator") in 2017. But
it doesn't use any arguments at that time. So this "$test_status" is useless
from beginning.
Reviewed-by: Zorro Lang <zlang@redhat.com>
> ;;
> *)
> _dump_err "format '$report' is not supported"
> --
> 2.35.3
>
next prev parent reply other threads:[~2022-06-22 4:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 19:29 [PATCH 0/6] check: minor cleanups and xunit report fix David Disseldorp
2022-06-20 19:29 ` [PATCH 1/6] check: avoid FSTYP=<fstyp parameter> repetition David Disseldorp
2022-06-22 4:27 ` Zorro Lang
2022-06-20 19:29 ` [PATCH 2/6] check: simplify check.time parsing David Disseldorp
2022-06-22 4:31 ` Zorro Lang
2022-06-20 19:29 ` [PATCH 3/6] report: drop unused _xunit_make_section_report parameter David Disseldorp
2022-06-22 4:37 ` Zorro Lang [this message]
2022-06-20 19:29 ` [PATCH 4/6] report: fix xunit tests count David Disseldorp
2022-06-22 5:03 ` Zorro Lang
2022-06-20 19:29 ` [PATCH 5/6] check: use arrays instead of separate n_ counters David Disseldorp
2022-06-22 5:11 ` Zorro Lang
2022-06-20 19:29 ` [PATCH 6/6] check: remove err and first_test variables David Disseldorp
2022-06-22 5:15 ` Zorro Lang
2022-06-22 5:21 ` [PATCH 0/6] check: minor cleanups and xunit report fix Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220622043718.pcdgu6n2mhbijv4x@zlang-mailbox \
--to=zlang@redhat.com \
--cc=ddiss@suse.de \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.